Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting no_std from the config file #69381

Merged
merged 2 commits into from
Feb 26, 2020

Commits on Feb 22, 2020

  1. Allow getting no_std from the config file

    Currently, it is only set correctly in the sanity checking implicit
    default fallback code. Having a config file at all will for force
    `no_std = false`.
    Ericson2314 committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    03ca0e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. bootstrap: Further centralize target defaulting logic.

    Background: targets can be specied with or without config files;
    unneccessarily differences in the logic between those cases has caused
    a) the bug I tried to fix in the previous commit, b) the bug I
    introduced in the previous commit.
    
    The solution is to make the code paths the same as much as possible.
    
    1. Targets are now not created from the `default` method. (I would both
    remove the impl if this was a public library, but just wrap it for
    convience becaues it's not.) Instead, there is a `from_triple` method
    which does the defaulting.
    
    2. Besides the sanity checking, use the new method in the code reading
    config files. Now `no_std` is overriden iff set explicitly just like the
    other fields which are optional in the TOML AST type.
    
    3. In sanity checking, just populate the map for all targets no matter
    what. That way do don't duplicate logic trying to be clever and remember
    which targets have "non standard" overrides. Sanity checking is back to
    just sanity checking, and out of the game of trying to default too.
    Ericson2314 committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    4f15867 View commit details
    Browse the repository at this point in the history