docs: Stdin::read_line: mention the appending #69405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup Very nice change, thank you! |
|
📌 Commit b3e0d27 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 24, 2020
Rollup of 5 pull requests Successful merges: - #69372 (Updates links in various Compiler Error Index entries) - #69385 (Relax str::get_unchecked precondition to permit empty slicing) - #69386 (Fix minor error in `MaybeUninit::get_mut()` doc example) - #69394 (Clean up E0367 explanation) - #69405 (docs: Stdin::read_line: mention the appending) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that
stdin().read_line()is an unpleasant footgun. Let's make it clearer in the documentation.