-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #69417
Rollup of 4 pull requests #69417
Commits on Feb 22, 2020
-
Relax str::get_unchecked precondition to permit empty slicing
Prior to this commit, `str` documented that `get_unchecked` had the precondition that "`begin` must come before `end`". This would appear to prohibit empty slices (i.e. begin == end). In practice, get_unchecked is called often with empty slices. Let's relax the precondition so as to allow them.
Configuration menu - View commit details
-
Copy full SHA for 9e41c4b - Browse repository at this point
Copy the full SHA 9e41c4bView commit details -
Fix doc example for
MaybeUninit::get_mut()
Suggested by @ametisf in rust-lang#65948 (comment) Co-Authored-By: Frantisek Fladung <fladufra@fel.cvut.cz>
Configuration menu - View commit details
-
Copy full SHA for 2cf339a - Browse repository at this point
Copy the full SHA 2cf339aView commit details
Commits on Feb 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ad47bf5 - Browse repository at this point
Copy the full SHA ad47bf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78e4bd1 - Browse repository at this point
Copy the full SHA 78e4bd1View commit details
Commits on Feb 24, 2020
-
Rollup merge of rust-lang#69385 - ridiculousfish:relax_get_unchecked,…
… r=nagisa Relax str::get_unchecked precondition to permit empty slicing Prior to this commit, `str` documented that `get_unchecked` had the precondition that "`begin` must come before `end`". This would appear to prohibit empty slices (i.e. begin == end). In practice, get_unchecked is called often with empty slices. Let's relax the precondition so as to allow them.
Configuration menu - View commit details
-
Copy full SHA for 6cc6a4b - Browse repository at this point
Copy the full SHA 6cc6a4bView commit details -
Rollup merge of rust-lang#69386 - danielhenrymantilla:maybe_uninit_do…
…cs_replace_chunk_with_windows, r=Dylan-DPC Fix minor error in `MaybeUninit::get_mut()` doc example In the `MaybeUninit::get_mut()` example I wanted to assert that the slice was sorted and mistakenly used `.chunks(2)` rather than `.windows(2)` to assert it, as @ametisf pointed out in rust-lang#65948 (comment) . This fixes it.
Configuration menu - View commit details
-
Copy full SHA for 036c83b - Browse repository at this point
Copy the full SHA 036c83bView commit details -
Rollup merge of rust-lang#69391 - memoryruins:memalias, r=Mark-Simula…
…crum Add rustdoc aliases to `ptr::copy` and `ptr::copy_nonoverlapping` This PR adds a [rustdoc alias](https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html#add-aliases-for-an-item-in-documentation-search) to `ptr::copy` and `ptr::copy_nonoverlapping` using the commonly used terms `memcpy` and `memmove`. The motivation for this PR is to improve discoverability for these functions, since I've noticed users overlook these functions on multiple occasions (and they have thus reached for [libc](https://crates.io/crates/libc) without need). Currently std docs state: https://doc.rust-lang.org/nightly/std/ptr/fn.copy_nonoverlapping.html > `copy_nonoverlapping` is semantically equivalent to C's `memcpy`, but with the argument order swapped. https://doc.rust-lang.org/nightly/std/ptr/fn.copy.html > `copy` is semantically equivalent to C's `memmove`, but with the argument order swapped. #### search results before adding a rustdoc alias: ![screenshot 6517](https://user-images.githubusercontent.com/6868531/75102985-78fbb680-55c2-11ea-8e41-04979e6fa6f6.png) ![screenshot 6518](https://user-images.githubusercontent.com/6868531/75102984-78632000-55c2-11ea-9673-8822aae636d1.png) #### after adding `#[doc(alias = "memcpy")]` and `#[doc(alias = "memmove")]`: ![screenshot 6516](https://user-images.githubusercontent.com/6868531/75102986-78fbb680-55c2-11ea-93b9-1929be940043.png) ![screenshot 6515](https://user-images.githubusercontent.com/6868531/75102987-78fbb680-55c2-11ea-9861-ce8a77a0c3b9.png)
Configuration menu - View commit details
-
Copy full SHA for 57eda9a - Browse repository at this point
Copy the full SHA 57eda9aView commit details -
Rollup merge of rust-lang#69394 - GuillaumeGomez:clean-up-0367, r=Dyl…
…an-DPC Clean up E0367 explanation r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for 3fd774b - Browse repository at this point
Copy the full SHA 3fd774bView commit details