-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rustc and bootstrap dependencies #69470
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Please do split out changes to dependencies of std (and friends), like hashbrown. I would also ask that the polonius changes are either dropped or split to a separate PR at least -- I'm not sure whether just updating polonius makes sense (cc @matthewjasper, perhaps?) |
Polonius is generally updated by @rust-lang/wg-polonius add needed. I don't think it should be updated separately. |
The polonius update is in-progress in #68993: it's still WIP as it's possible it'll contain more rustc changes than updating |
@mati865 thanks for working on the polonius update! However, it requires new facts to be emitted in addition to the API changes, I'll be taking care of it in #69482. As Matthew said, the WG usually updates both polonius and rustc in tandem, as it requires a bit of choreography to update both because of changes to fact generation, testing, and so on. |
It's unclear to me if you mean separate commits or PRs.
Dropped. |
ping from triage: thanks. |
Separate PRs for each std dependency update, unless it makes sense to couple them (e.g., like the backtrace update I just approved - #69729). Please also prepare a summary of the upstream changes for the std dependency changes. |
@bors r+ Thanks! |
📌 Commit 78db865ae56ed2d49dadbd91e056d7dff61ad2e7 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
Something has broke and GitHub closed PR by itself. |
@bors r+ |
📌 Commit f5e702d has been approved by |
⌛ Testing commit f5e702d with merge b77c05fb3b027f0a822bd768a9134a1ca338c788... |
💔 Test failed - checks-azure |
Appears to be spurious chocolatey issue. @bors retry |
@mati865: 🔑 Insufficient privileges: not in try users |
@bors retry |
@bors p=1 |
☀️ Test successful - checks-azure |
No description provided.