Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rustc and bootstrap dependencies #69470

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Feb 25, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2020
@Mark-Simulacrum
Copy link
Member

Please do split out changes to dependencies of std (and friends), like hashbrown. I would also ask that the polonius changes are either dropped or split to a separate PR at least -- I'm not sure whether just updating polonius makes sense (cc @matthewjasper, perhaps?)

Cargo.lock Outdated Show resolved Hide resolved
@matthewjasper
Copy link
Contributor

Polonius is generally updated by @rust-lang/wg-polonius add needed. I don't think it should be updated separately.

@lqd
Copy link
Member

lqd commented Feb 25, 2020

The polonius update is in-progress in #68993: it's still WIP as it's possible it'll contain more rustc changes than updating polonius-engine, but those may also be split into another different PR.

@lqd
Copy link
Member

lqd commented Feb 26, 2020

@mati865 thanks for working on the polonius update! However, it requires new facts to be emitted in addition to the API changes, I'll be taking care of it in #69482.

As Matthew said, the WG usually updates both polonius and rustc in tandem, as it requires a bit of choreography to update both because of changes to fact generation, testing, and so on.

@mati865
Copy link
Contributor Author

mati865 commented Feb 26, 2020

Please do split out changes to dependencies of std (and friends), like hashbrown.

It's unclear to me if you mean separate commits or PRs.

I would also ask that the polonius changes are either dropped or split to a separate PR

Dropped.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020
@JohnCSimon
Copy link
Member

ping from triage:
@Mark-Simulacrum - mati865 is asking for clarification

thanks.

@Mark-Simulacrum
Copy link
Member

Separate PRs for each std dependency update, unless it makes sense to couple them (e.g., like the backtrace update I just approved - #69729). Please also prepare a summary of the upstream changes for the std dependency changes.

@mati865 mati865 changed the title Upgrade dependencies Upgrade rustc and bootstrap dependencies Mar 12, 2020
@varkor
Copy link
Member

varkor commented Mar 13, 2020

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 13, 2020

📌 Commit 78db865ae56ed2d49dadbd91e056d7dff61ad2e7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2020
@bors
Copy link
Contributor

bors commented Mar 26, 2020

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout deps (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self deps --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging src/librustc/Cargo.toml
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2020
@mati865 mati865 closed this Mar 26, 2020
@mati865 mati865 deleted the deps branch March 26, 2020 13:08
@mati865 mati865 restored the deps branch March 26, 2020 13:11
@mati865 mati865 deleted the deps branch March 26, 2020 13:13
@mati865 mati865 restored the deps branch March 26, 2020 13:14
@mati865
Copy link
Contributor Author

mati865 commented Mar 26, 2020

Something has broke and GitHub closed PR by itself.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2020

📌 Commit f5e702d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2020
@bors
Copy link
Contributor

bors commented Mar 26, 2020

⌛ Testing commit f5e702d with merge b77c05fb3b027f0a822bd768a9134a1ca338c788...

@bors
Copy link
Contributor

bors commented Mar 26, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2020
@mati865
Copy link
Contributor Author

mati865 commented Mar 26, 2020

Appears to be spurious chocolatey issue.

@bors retry

@bors
Copy link
Contributor

bors commented Mar 26, 2020

@mati865: 🔑 Insufficient privileges: not in try users

@cuviper
Copy link
Member

cuviper commented Mar 26, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Mar 27, 2020

⌛ Testing commit f5e702d with merge b9ac291...

@bors
Copy link
Contributor

bors commented Mar 27, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing b9ac291 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2020
@bors bors merged commit b9ac291 into rust-lang:master Mar 27, 2020
@bors bors mentioned this pull request Mar 27, 2020
@mati865 mati865 deleted the deps branch March 27, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants