note that find(f) is equivalent to filter(f).next() in the docs. #69501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/libcore/iter/traits/iterator.rs
Outdated
| @@ -2119,6 +2119,7 @@ pub trait Iterator { | |||
| /// | |||
| /// `find()` is short-circuiting; in other words, it will stop processing | |||
| /// as soon as the closure returns `true`. | |||
| /// `iter.find(f)` is equivalent to `iter.filter(f).next()`. | |||
There was a problem hiding this comment.
Can this go in its own paragraph near the end? It's not really related to the short-circuiting.
matthiaskrgr
force-pushed
the
find_note
branch
from
9746ae9
to
5098188
Compare
tesuji
reviewed
Feb 27, 2020
src/libcore/iter/traits/iterator.rs
Outdated
| @@ -2120,6 +2120,8 @@ pub trait Iterator { | |||
| /// `find()` is short-circuiting; in other words, it will stop processing | |||
| /// as soon as the closure returns `true`. | |||
| /// | |||
| /// `iter.find(f)` is equivalent to `iter.filter(f).next()`. | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Another thought: Let's rephrase the sentence: and move it to |
matthiaskrgr
force-pushed
the
find_note
branch
from
5098188
to
31b9764
Compare
|
@bors r=ecstatic-morse rollup |
|
📌 Commit 31b9764 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 28, 2020
Rollup of 9 pull requests Successful merges: - #69379 (Fail on multiple declarations of `main`.) - #69430 (librustc_typeck: remove loop that never actually loops) - #69449 (Do not ping PR reviewers in toolstate breakage) - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages) - #69495 (don't take redundant references to operands) - #69496 (use find(x) instead of filter(x).next()) - #69501 (note that find(f) is equivalent to filter(f).next() in the docs.) - #69527 (Ignore untracked paths when running `rustfmt` on repository.) - #69529 (don't use .into() to convert types into identical types.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ecstatic-morse