Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename libsyntax to librustc_ast #69592

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Rename libsyntax to librustc_ast #69592

merged 3 commits into from
Mar 1, 2020

Conversation

petrochenkov
Copy link
Contributor

This was the last rustc crate that wasn't following the rustc_* naming convention.

Follow-up to #67763.

@Centril
Copy link
Contributor

Centril commented Feb 29, 2020

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Feb 29, 2020

📌 Commit e08c279 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Feb 29, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 29, 2020
@Centril
Copy link
Contributor

Centril commented Mar 1, 2020

Let's bump this cause this will be massively bitrotty: @bors p=10

@bors
Copy link
Contributor

bors commented Mar 1, 2020

⌛ Testing commit e08c279 with merge 2917d99...

@bors
Copy link
Contributor

bors commented Mar 1, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 2917d99 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 1, 2020
@bors bors merged commit 2917d99 into rust-lang:master Mar 1, 2020
This was referenced Mar 1, 2020
Merged
Merged
@rust-highfive rust-highfive mentioned this pull request Mar 1, 2020
Closed
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #69592!

Tested on commit 2917d99.
Direct link to PR: #69592

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 1, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#69592!
7537a62 
Tested on commit rust-lang/rust@2917d99.
Direct link to PR: <rust-lang/rust#69592>

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
This was referenced Mar 1, 2020
Merged
Merged
Merged
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Mar 1, 2020
@JohnTitor
Rustup to rust-lang/rust#69592
4253aa7
This was referenced Mar 1, 2020
Closed
Merged
Merged
Merged
Merged
Merged
eddyb
eddyb reviewed Mar 2, 2020
View reviewed changes
src/bootstrap/dist.rs
Comment on lines 998 to +999
"src/librustc",
"src/libsyntax",
"src/librustc_ast",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why these are included here, is this left over from when src/libproc_macro had a dependency on these two crates? If so, we've shipping a lot of pointless rustc source code for a while now.

cc @Mark-Simulacrum @dtolnay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were added by #58269 to fix #58268

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, but why these crates specifically? #58268 doesn't explain why those vs the entire source distribution (which is still available.. somehow, right?)

Copy link
Member

@RalfJung RalfJung Mar 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My best guess: intellij-rust/intellij-rust#2623 (referenced by that issue) mentions compiler plugins.

I don't think the entire source distribution is otherwise available as a rustup component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this list is probably missing a couple crates in terms of plugin development and nobody brought this up, maybe it's time to remove them. I'll bring this up on the existing issue.

@eddyb
Copy link
Member

eddyb commented Mar 2, 2020

@petrochenkov @Centril Do we plan to remove the redudancy of rustc_ast::ast?
Similar to how we have use rustc_hir as hir; imports for the HIR, we should be able to now also have use rustc_ast as ast; IMO.

It would also be nice to be able to write paths like ast::visit::walk_....

@RalfJung RalfJung mentioned this pull request Mar 2, 2020
Merged
@ehuss ehuss mentioned this pull request Mar 2, 2020
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Mar 2, 2020
@bors
Auto merge of #7955 - ehuss:fix-plugin-syntax-rename, r=alexcrichton
cc5a5e5 
Fix plugin tests for latest nightly.

Crate was renamed in rust-lang/rust#69592.
@calebcartwright calebcartwright mentioned this pull request Mar 4, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
@Centril
Rollup merge of rust-lang#69631 - RalfJung:rust-src, r=Mark-Simulacrum
efad0cb 
remove non-sysroot sources from rust-src component

See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources.

OTOH, @eddyb [wrote](rust-lang#58269 (comment))

> Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

So maybe there is some good reason to keep these? Then we should have a comment explaining that reason.

Cc @eddyb @taeguk @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
@Centril
Rollup merge of rust-lang#69631 - RalfJung:rust-src, r=Mark-Simulacrum
b3c405c 
remove non-sysroot sources from rust-src component

See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources.

OTOH, @eddyb [wrote](rust-lang#58269 (comment))

> Yeah, my question is why librustc_plugin specifically? Everything else makes sense.

So maybe there is some good reason to keep these? Then we should have a comment explaining that reason.

Cc @eddyb @taeguk @Mark-Simulacrum
ehuss pushed a commit to ehuss/cargo that referenced this pull request Mar 16, 2020
@bors @ehuss
Auto merge of rust-lang#7955 - ehuss:fix-plugin-syntax-rename, r=alex…
0a77863 
…crichton

Fix plugin tests for latest nightly.

Crate was renamed in rust-lang/rust#69592.
@kvark kvark mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@eddyb eddyb eddyb left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @Centril @bors @rust-highfive @eddyb @RalfJung