Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the no_debug feature #69667

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Remove the no_debug feature #69667

merged 3 commits into from
Mar 8, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2020
nikomatsakis
nikomatsakis approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me but I agree we should remove the constant that is no longer used, rather than leave it there with a comment that it is no longer used (unless there is some reason to keep it)

@JohnTitor
Copy link
Member Author

Removed the const as well.
@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Mar 6, 2020

📌 Commit 18080e6 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Mar 6, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2020
@Centril Centril mentioned this pull request Mar 7, 2020
Merged
bors added a commit that referenced this pull request Mar 8, 2020
@bors
Auto merge of #69804 - Centril:rollup-u86dc1g, r=Centril
f943349 
Rollup of 8 pull requests

Successful merges:

 - #69667 (Remove the `no_debug` feature)
 - #69687 (resolve, inconsistent binding mode: tweak wording)
 - #69708 (On mismatched delimiters, only point at empty blocks that are in the same line)
 - #69765 (reduce test size for Miri)
 - #69773 (fix various typos)
 - #69787 (mir::Local is Copy we can pass it by value in these cases)
 - #69794 (Add `Layout::dangling()` to return a well-aligned `NonNull<u8>`)
 - #69797 (Correct version that relaxed orphan rules)

Failed merges:

r? @ghost
@bors bors merged commit 614cd8d into rust-lang:master Mar 8, 2020
@JohnTitor JohnTitor deleted the no-debug branch March 8, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnTitor @bors @nikomatsakis @bjorn3