Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link to std::str active #69728

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Make link to std::str active #69728

merged 1 commit into from
Mar 6, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Closes #69726.

r? @dtolnay

@LeSeulArtichaut
Copy link
Contributor Author

Oops, wrong ping 😅
r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned dtolnay Mar 5, 2020
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2020
@steveklabnik
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2020

📌 Commit 6ed4829 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 5, 2020
Merged
bors added a commit that referenced this pull request Mar 5, 2020
@bors
Auto merge of #69746 - Dylan-DPC:rollup-wr6dvdk, r=Dylan-DPC
b818ccc 
Rollup of 8 pull requests

Successful merges:

 - #69697 (Add explanation for E0380)
 - #69698 (Use associated constants of integer types)
 - #69711 (Update macros.rs: fix documentation typo.)
 - #69713 (more clippy cleanups)
 - #69728 (Make link to `std::str` active)
 - #69732 (Clean E0382 and E0384 explanations)
 - #69736 (even more clippy cleanups)
 - #69742 (Fixed a typo)

Failed merges:

r? @ghost
@bors bors merged commit 7aac135 into rust-lang:master Mar 6, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the patch-1 branch March 6, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core::str docs missing link to std::str
5 participants
@LeSeulArtichaut @steveklabnik @bors @dtolnay @JohnTitor