Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #69856

Closed
wants to merge 36 commits into from
Closed

Rollup of 6 pull requests #69856

wants to merge 36 commits into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 9, 2020

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 30 commits February 27, 2020 14:51
@GuillaumeGomez
Remove "important traits" feature
1244ced
@GuillaumeGomez
Remove spotlight usage
13c6d58
@spastorino
Make PlaceRef lifetimes of Place::as_ref be both 'tcx
7859f0e
@spastorino
Make PlaceRef lifetimes of LocalAnalyzer::process_place be both 'tcx
812e62f
@spastorino
Make PlaceRef lifetimes of codegen_place be both 'tcx
1a1dcfa
@spastorino
Make PlaceRef lifetimes of monomorphized_place_ty be both 'tcx
2af5e87
@spastorino
Make PlaceRef lifetimes of RootPlace be both 'tcx
a20d54f
@spastorino
Make PlaceRef lifetimes of borrow_conflict_place be both 'tcx
842af36
@spastorino
Make PlaceRef lifetimes of move_error_reported be both 'tcx
f54e863
@spastorino
Make PlaceRef lifetimes of uninitialized_error_reported be both 'tcx
6200f5c
@spastorino
Make PlaceRef lifetimes of move_path_closest_to be both 'tcx
e32ee55
@spastorino
Make PlaceRef lifetimes of move_path_for_place be both 'tcx
634a167
@spastorino
Make PlaceRef lifetimes of is_upvar_field_projection be both 'tcx
c6f1244
@spastorino
Make PlaceRef lifetimes of add_moved_or_invoked_closure_note be both …
6f23650 
…'tcx
@spastorino
Make PlaceRef lifetimes of describe_field be both 'tcx
eb67eca
@spastorino
Make PlaceRef lifetimes of borrowed_content_source be both 'tcx
a30f55f
@spastorino
Make PlaceRef lifetimes of move_spans be both 'tcx
bd4dad4
@spastorino
Make PlaceRef lifetimes of closure_span be both 'tcx
46d85e5
@spastorino
Make PlaceRef lifetimes of classify_drop_access_kind be both 'tcx
a32afa3
@spastorino
Make PlaceRef lifetimes of is_prefix_of be both 'tcx
a5d1e18
@spastorino
Make PlaceRef lifetimes of in_projection be both 'tcx
2cb2559
@spastorino
PlaceRef<'a, 'tcx> -> PlaceRef<'tcx>
b11cd0b
@petrochenkov
rustc_metadata: Give decoder access to whole crate store
c1df945
@petrochenkov
rustc_metadata: Move some code from impl CrateMetadataRef to `impl …
41374d7 
…CrateMetadata`
@TimDiekmann
Allow ZSTs in AllocRef
f77afc8
@JohnTitor
Check if output is immediate value
d32924f
@Zoxc
Move analysis to the query macro
6701215
@Zoxc
Remove the need for no_force
cbce217
@Zoxc
Remove the no_force query attribute
f445077
@Zoxc
Add a comment to recover.
2f12009
@Centril
Rollup merge of rust-lang#69475 - Zoxc:no-no-force, r=michaelwoerister
0cbaefc 
Remove the `no_force` query attribute

This removes the `no_force` query attribute and instead uses the `DepNodeParams` trait to find out if a query can be forced.

Also the `analysis` query is moved to the query macro.

r? @eddyb
@Centril
Rollup merge of rust-lang#69514 - GuillaumeGomez:remove-spotlight, r=…
dd6a074 
…kinnison

Remove spotlight

I had a few comments saying that this feature was at best misunderstood or not even used so I decided to organize a poll about on [twitter](https://twitter.com/imperioworld_/status/1232769353503956994). After 87 votes, the result is very clear: it's not useful. Considering the amount of code we have just to run it, I think it's definitely worth it to remove it.

r? @kinnison

cc @ollie27
@Centril
Rollup merge of rust-lang#69677 - petrochenkov:spancode, r=eddyb
522b1d0 
rustc_metadata: Give decoder access to whole crate store

Pre-requisite for rust-lang#68941.
r? @eddyb
@Centril
Rollup merge of rust-lang#69714 - spastorino:place-ref-lifetime, r=ol…
3407442 
…i-obk

Make PlaceRef take just one lifetime

r? @eddyb
@Centril
Rollup merge of rust-lang#69799 - TimDiekmann:zst, r=Amanieu
e3f040f 
Allow ZSTs in `AllocRef`

Allows ZSTs in all `AllocRef` methods. The implementation of `AllocRef` for `Global` and `System` were adjusted to reflect those changes.

This is the second item on the roadmap to support ZSTs in `AllocRef`: rust-lang/wg-allocators#38 (comment)
After this has landed, I will adapt `RawVec`, but since this will be a pretty big overhaul, it makes sense to do a different PR for it.

~~Requires rust-lang#69794 to land first~~

r? @Amanieu
@Centril
Rollup merge of rust-lang#69836 - JohnTitor:immediate-outputs, r=nagisa
da9d266 
Check if output is immediate value

Fixes rust-lang#62046

r? @nagisa
@Centril
Copy link
Contributor Author

Centril commented Mar 9, 2020

@bors r+ p=1001 rollup=never

@bors
Copy link
Contributor

bors commented Mar 9, 2020

📌 Commit da9d266 has been approved by Centril

@bors
Copy link
Contributor

bors commented Mar 9, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2020
@Centril Centril added the rollup A PR which is a rollup label Mar 9, 2020
@bors
Copy link
Contributor

bors commented Mar 9, 2020

⌛ Testing commit da9d266 with merge 3127f4a...

bors added a commit that referenced this pull request Mar 9, 2020
@bors
Auto merge of #69856 - Centril:rollup-0uvh4n9, r=Centril
3127f4a 
Rollup of 6 pull requests

Successful merges:

 - #69475 (Remove the `no_force` query attribute)
 - #69514 (Remove spotlight)
 - #69677 (rustc_metadata: Give decoder access to whole crate store)
 - #69714 (Make PlaceRef take just one lifetime)
 - #69799 (Allow ZSTs in `AllocRef`)
 - #69836 (Check if output is immediate value)

Failed merges:

r? @ghost
@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-09T15:29:51.4314254Z Prepare build directory.
2020-03-09T15:29:51.4696604Z Set build variables.
2020-03-09T15:29:51.4729217Z Download all required tasks.
2020-03-09T15:29:51.4863827Z Downloading task: Bash (3.163.1)
2020-03-09T15:29:52.5299981Z Checking job knob settings.
2020-03-09T15:29:52.5319395Z Finished checking job knob settings.
2020-03-09T15:29:52.5748207Z ##[section]Finishing: Initialize job
2020-03-09T15:29:52.6111799Z ##[section]Starting: Configure Job Name
2020-03-09T15:29:52.7357517Z ==============================================================================
2020-03-09T15:29:52.7358200Z Task         : Bash

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Contributor

bors commented Mar 9, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2020
@Centril Centril closed this Mar 10, 2020
@Centril Centril deleted the rollup-0uvh4n9 branch March 10, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Centril @bors @rust-highfive @GuillaumeGomez @spastorino @petrochenkov @TimDiekmann @JohnTitor @Zoxc