Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

def_collector: Fully visit async functions #70011

Merged
merged 1 commit into from
Mar 15, 2020
Merged

def_collector: Fully visit async functions #70011

merged 1 commit into from
Mar 15, 2020

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Mar 14, 2020 •
edited
Loading

We forgot to visit attributes previously, it caused ICEs.

Special treatment of async functions is also moved from visit_item to visit_fn to reuse more of the default visitor.

Fixes #67778.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2020
@petrochenkov petrochenkov mentioned this pull request Mar 14, 2020
Closed
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Mar 14, 2020 •
edited
Loading

Actually, maybe this can be cleaned up to only specialize visit_fn for async functions instead of visit_item. I'll try.

UPDATE: Done.

@Centril
Copy link
Contributor

Centril commented Mar 15, 2020

Nice! r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2020

📌 Commit 2093d83 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Mar 15, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2020
@Centril Centril mentioned this pull request Mar 15, 2020
Merged
bors added a commit that referenced this pull request Mar 15, 2020
@bors
Auto merge of #70024 - Centril:rollup-cppmaxr, r=Centril
e0f5df0 
Rollup of 8 pull requests

Successful merges:

 - #69528 (Add undo_leak to reset RefCell borrow state)
 - #69589 (ast: `Mac`/`Macro` -> `MacCall`)
 - #69661 (Implement From<&mut str> for String)
 - #69988 (rustc_metadata: Remove `rmeta::MacroDef`)
 - #70006 (resolve: Fix two issues in fresh binding disambiguation)
 - #70011 (def_collector: Fully visit async functions)
 - #70013 (Return feature gate as a `Symbol` )
 - #70018 (Fix "since" field for `Once::is_complete`'s `#[stable]` attribute)

Failed merges:

r? @ghost
@bors bors merged commit d74c5cd into rust-lang:master Mar 15, 2020
@jonas-schievink jonas-schievink mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async fn ICEs in macro on stable
5 participants
@petrochenkov @rust-highfive @Centril @bors @estebank