Skip to content

Rollup of 7 pull requests #70063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Rollup of 7 pull requests #70063

wants to merge 19 commits into from

Conversation

@Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

oli-obk and others added 19 commits March 11, 2020 13:55
@oli-obk
Compute the correct layout for variants of uninhabited enums and read…
cdc7304 
…d a long lost assertion

This reverts part of commit 9712fa4.
@oli-obk @RalfJung
Comment nits
ec88ffa 
Co-Authored-By: Ralf Jung <post@ralfj.de>
@oli-obk
Rustfmt and adjust capitalization
74608c7
@petrochenkov
resolve: Simplify fn report_privacy_error
71ebc61 
by factoring out `fn ctor_fields_span` into a separate function
@petrochenkov
resolve: Print import chains on privacy errors
580c6a2
@andjo403
Update the mir inline costs
afa940b 
handle that when mir is lowered to llvm-ir more code is generated.
landingpads generates 10 llvm-ir instructions
and resume 9 llvm-ir instructions.
@petrochenkov
Add the "consider importing it directly" label to public imports as well
f4083c6
@matthewjasper
Ensure HAS_FREE_LOCAL_NAMES is set for ReFree
f4eb6ed
@petrochenkov
resolve: Fix regression in resolution of raw keywords in paths
e80cb20
@Centril
VariantSizeDifferences: bail on SizeOverflow
81099c2
@tesuji
Use sublice patterns to avoid computing the len
ce5e49f
@tesuji
Fix wrong deref
e1bc9af
@Dylan-DPC
Rollup merge of rust-lang#69768 - oli-obk:union_field_ice, r=eddyb,Ra…
dd0d904 
…lfJung

Compute the correct layout for variants of uninhabited enums

r? @eddyb
cc @RalfJung

fixes rust-lang#69191
cc rust-lang#69763
@Dylan-DPC
Rollup merge of rust-lang#69811 - petrochenkov:privdiag2, r=estebank
f6703ef 
resolve: Print import chains on privacy errors

A part of rust-lang#67951 that doesn't require hacks.
r? @estebank
@Dylan-DPC
Rollup merge of rust-lang#69881 - Centril:fix-69485, r=oli-obk
2dab4f4 
VariantSizeDifferences: bail on SizeOverflow

Fixes rust-lang#69485.

r? @oli-obk
@Dylan-DPC
Rollup merge of rust-lang#69934 - andjo403:inlinecost, r=wesleywiser
7e8c3b2 
Update the mir inline costs

handle that when mir is lowered to llvm-ir more code is generated.
Landingpads generates 10 llvm-ir instructions
and resume 9 llvm-ir instructions.

r? @wesleywiser
@Dylan-DPC
Rollup merge of rust-lang#69956 - matthewjasper:fix-region-flags, r=n…
875392d 
…ikomatsakis

Ensure HAS_FREE_LOCAL_NAMES is set for ReFree

This fixes a bug introduced by rust-lang#69469.
I don't have any ideas on how to reate a regression test for this.
@Dylan-DPC
Rollup merge of rust-lang#70000 - petrochenkov:rawkeypars, r=davidtwco
ca2e83d 
resolve: Fix regression in resolution of raw keywords in paths

Fixes rust-lang#63882.
@Dylan-DPC
Rollup merge of rust-lang#70046 - lzutao:patch-1, r=Centril
d7eabe5 
Use sublice patterns to avoid computing the len

r? @Centril
@Dylan-DPC-zz Dylan-DPC-zz deleted the rollup-q4h3yya branch March 17, 2020 02:10
@rust-highfive
Copy link
Contributor

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-17T02:10:37.3471018Z ========================== Starting Command Output ===========================
2020-03-17T02:10:37.3474625Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/605a3c4b-5d7f-4750-bb11-8bcff7590fcf.sh
2020-03-17T02:10:37.3474917Z 
2020-03-17T02:10:37.3479755Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-17T02:10:37.3500494Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70063/merge to s
2020-03-17T02:10:37.3503703Z Task         : Get sources
2020-03-17T02:10:37.3504012Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T02:10:37.3504316Z Version      : 1.0.0
2020-03-17T02:10:37.3504516Z Author       : Microsoft
---
2020-03-17T02:10:38.3428527Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-17T02:10:38.3433958Z ##[command]git config gc.auto 0
2020-03-17T02:10:38.3437668Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-17T02:10:38.3441002Z ##[command]git config --get-all http.proxy
2020-03-17T02:10:38.3446899Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70063/merge:refs/remotes/pull/70063/merge
2020-03-17T02:10:38.6163180Z fatal: couldn't find remote ref refs/pull/70063/merge
2020-03-17T02:10:38.7017797Z ##[warning]Git fetch failed with exit code 128, back off 6.319 seconds before retry.
2020-03-17T02:10:44.9595787Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70063/merge:refs/remotes/pull/70063/merge
2020-03-17T02:10:45.6435429Z fatal: couldn't find remote ref refs/pull/70063/merge
2020-03-17T02:10:45.7155817Z ##[warning]Git fetch failed with exit code 128, back off 3.264 seconds before retry.
2020-03-17T02:10:48.9116324Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70063/merge:refs/remotes/pull/70063/merge
2020-03-17T02:10:49.6073310Z fatal: couldn't find remote ref refs/pull/70063/merge
2020-03-17T02:10:49.6665235Z ##[error]Git fetch failed with exit code: 128
2020-03-17T02:10:49.6680236Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70063/merge to s
2020-03-17T02:10:49.7103491Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70063/merge to s
2020-03-17T02:10:49.7108902Z Task         : Get sources
2020-03-17T02:10:49.7109245Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T02:10:49.7109589Z Version      : 1.0.0
2020-03-17T02:10:49.7109832Z Author       : Microsoft
2020-03-17T02:10:49.7109832Z Author       : Microsoft
2020-03-17T02:10:49.7110190Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-17T02:10:49.7110599Z ==============================================================================
2020-03-17T02:10:50.0248970Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70063/merge to s
2020-03-17T02:10:50.0336842Z Cleaning up task key
2020-03-17T02:10:50.0338150Z Start cleaning up orphan processes.
2020-03-17T02:10:50.0476741Z ##[section]Finishing: Finalize Job
2020-03-17T02:10:50.0518076Z ##[section]Finishing: Linux x86_64-gnu-tools

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Dylan-DPC-zz @rust-highfive @oli-obk @petrochenkov @andjo403 @matthewjasper @Centril @tesuji @Dylan-DPC