Skip to content

Use if let instead of match when only matching a single variant (clippy::single_match) #70326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Use if let instead of match when only matching a single variant (clippy::single_match) #70326

merged 1 commit into from
Mar 30, 2020

Conversation

matthiaskrgr
Copy link
Member

Makes code more compact and reduces nesting.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2020
Xanewok
Xanewok reviewed Mar 24, 2020
View reviewed changes
@bors
Copy link
Collaborator

bors commented Mar 25, 2020

☔ The latest upstream changes (presumably #70383) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 25, 2020

☔ The latest upstream changes (presumably #70404) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

The code changes look ok, please deal with the merge conflicts.

@matthiaskrgr
Copy link
Member Author

rebased

@bors
Copy link
Collaborator

bors commented Mar 27, 2020

☔ The latest upstream changes (presumably #70451) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 28, 2020

☔ The latest upstream changes (presumably #70261) made this pull request unmergeable. Please resolve the merge conflicts.

@matthiaskrgr
Copy link
Member Author

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Mar 28, 2020
Centril
Centril reviewed Mar 29, 2020
View reviewed changes
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2020
@bors
Copy link
Collaborator

bors commented Mar 30, 2020

☔ The latest upstream changes (presumably #70536) made this pull request unmergeable. Please resolve the merge conflicts.

@matthiaskrgr
Use if let instead of match when only matching a single variant (clip…
9bba047 
…py::single_match)

Makes code more compact and reduces nestig.
@matthiaskrgr
Copy link
Member Author

@rustbot modify labels -S-waiting-on-author, +S-waiting-on-review

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2020

Error: Parsing label command in comment failed: ...ify labels|error: must have : or to as label starter at >| -S-waitin...

Please let @rust-lang/release know if you're having trouble with this bot.

@matthiaskrgr
Copy link
Member Author

@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2020
@Centril
Copy link
Contributor

Centril commented Mar 30, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 30, 2020

📌 Commit 9bba047 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2020
@bors
Copy link
Collaborator

bors commented Mar 30, 2020

⌛ Testing commit 9bba047 with merge 53409fbd54abf4209ccefc8e44f95b971439fbb1...

@bors
Copy link
Collaborator

bors commented Mar 30, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2020
@Centril
Copy link
Contributor

Centril commented Mar 30, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2020
@bors
Copy link
Collaborator

bors commented Mar 30, 2020

⌛ Testing commit 9bba047 with merge a80ec3b...

@bors
Copy link
Collaborator

bors commented Mar 30, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing a80ec3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2020
@bors bors merged commit a80ec3b into rust-lang:master Mar 30, 2020
@matthiaskrgr matthiaskrgr deleted the cl1ppy_single_match branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Centril Centril Centril left review comments

@Xanewok Xanewok Xanewok left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @rust-highfive @bors @estebank @rustbot @Centril @Xanewok