Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: allow target to be a symlink #70409

Merged
merged 1 commit into from
Mar 26, 2020
Merged

gitignore: allow target to be a symlink #70409

merged 1 commit into from
Mar 26, 2020

Conversation

mathstuf
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2020
@Centril
Copy link
Contributor

Centril commented Mar 25, 2020

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 25, 2020 •
edited
Loading

Huh. Okay. @bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 25, 2020

📌 Commit 1dc722c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2020
@bors
Copy link
Contributor

bors commented Mar 25, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Mar 25, 2020

📌 Commit 1dc722c has been approved by Mark-Simulacrum

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 25, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2020
@bors
Auto merge of rust-lang#70412 - Dylan-DPC:rollup-yuq2mfy, r=Dylan-DPC
e4519e2 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#69700 (Rename LayoutDetails to just Layout.)
 - rust-lang#70392 (Make x.py compatible with python 3.8.)
 - rust-lang#70406 (Clean up E0458 explanation)
 - rust-lang#70407 (Avoid tagging as I-nominated on toolstate breakage)
 - rust-lang#70409 (gitignore: allow target to be a symlink)

Failed merges:

 - rust-lang#70375 (avoid catching InterpError)

r? @ghost
@bors bors merged commit 84a2865 into rust-lang:master Mar 26, 2020
@mathstuf mathstuf deleted the gitignore-target-symlink branch March 26, 2020 13:09
@taiki-e taiki-e mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mathstuf @rust-highfive @Centril @Mark-Simulacrum @bors @nikomatsakis