Polonius: update to 0.12.1, fix more move errors false positives, update test expectations #70546
+20
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix some move errors false positives
This will fix the other move errors false positives: emitting the fact at the start point caused accesses to be at the same point as an initialization fact of the return place of a call on the following block, which emitted an error.
trivial formatting changes
trivial diagnostics wording change
…supply-region.rs trivial diagnostics grammar change
Some impl Trait fixes lead to locating more accurately the cause of a universal region error with a user annotation
Trivial diagnostics grammar change
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Mar 30, 2020
|
@bors r+ rollup |
|
📌 Commit 5af11d2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 30, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#70479 (avoid creating unnecessary reference in Windows Env iterator) - rust-lang#70546 (Polonius: update to 0.12.1, fix more move errors false positives, update test expectations) - rust-lang#70559 (fix BTreeMap test compilation with Miri) - rust-lang#70567 (Fix broken link in README) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
polonius-engineto version 0.12.1 to fix some move errors false positivesIn my opinion, this is safe to rollup.
r? @nikomatsakis