[WIP] Allow functions to be inlined across crates without an inline attribute #70550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoxc
changed the title
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 9d6086f with merge 72176503fc0d08a32adfdda3aea038c0f6561a0e... |
|
☀️ Try build successful - checks-azure |
|
Queued 72176503fc0d08a32adfdda3aea038c0f6561a0e with parent 4911572, future comparison URL. |
|
Wow those are some nice gains! |
|
inflate-check clean:
Similar for other crates. Some functions called by |
|
Closing this pull request as Zoxc is stepping back from compiler development; see rust-lang/team#316. |
|
I might pick this one up. Having to put |
|
@jonas-schievink If you pick this up, there's still some test failures if the threshold is high (related to allocators). MIR inlining is likely to have a large interaction with this, so it might be less beneficial once we get that working. Also using ThinLTO might be better for optimizing the compiler itself, but that is blocked on LLVM 10 due to ThinLTO bugs, These benchmarks show that we don't do enough inlining in the compiler currently, and one way or another we should find a way to increase that. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2023
Automatically enable cross-crate inlining for small functions This is basically reviving rust-lang#70550 The `#[inline]` attribute can have a significant impact on code generation or runtime performance (because it enables inlining between CGUs where it would normally not happen) and also on compile-time performance (because it enables MIR inlining). But it has to be added manually, which is awkward. This PR factors whether a DefId is cross-crate inlinable into a query, and replaces all uses of `CodegenFnAttrs::requests_inline` with this new query. The new query incorporates all the other logic that is used to determine whether a Def should be treated as cross-crate-inlinable, and as a last step inspects the function's optimized_mir to determine if it should be treated as cross-crate-inlinable. The heuristic implemented here is deliberately conservative; we only infer inlinability for functions whose optimized_mir does not contain any calls or asserts. I plan to study adjusting the cost model later, but for now the compile time implications of this change are so significant that I think this very crude heuristic is well worth landing.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2023
Automatically enable cross-crate inlining for small functions This is basically reviving rust-lang#70550 The `#[inline]` attribute can have a significant impact on code generation or runtime performance (because it enables inlining between CGUs where it would normally not happen) and also on compile-time performance (because it enables MIR inlining). But it has to be added manually, which is awkward. This PR factors whether a DefId is cross-crate inlinable into a query, and replaces all uses of `CodegenFnAttrs::requests_inline` with this new query. The new query incorporates all the other logic that is used to determine whether a Def should be treated as cross-crate-inlinable, and as a last step inspects the function's optimized_mir to determine if it should be treated as cross-crate-inlinable. The heuristic implemented here is deliberately conservative; we only infer inlinability for functions whose optimized_mir does not contain any calls or asserts. I plan to study adjusting the cost model later, but for now the compile time implications of this change are so significant that I think this very crude heuristic is well worth landing.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2023
Automatically enable cross-crate inlining for small functions This is basically reviving rust-lang#70550 The `#[inline]` attribute can have a significant impact on code generation or runtime performance (because it enables inlining between CGUs where it would normally not happen) and also on compile-time performance (because it enables MIR inlining). But it has to be added manually, which is awkward. This PR factors whether a DefId is cross-crate inlinable into a query, and replaces all uses of `CodegenFnAttrs::requests_inline` with this new query. The new query incorporates all the other logic that is used to determine whether a Def should be treated as cross-crate-inlinable, and as a last step inspects the function's optimized_mir to determine if it should be treated as cross-crate-inlinable. The heuristic implemented here is deliberately conservative; we only infer inlinability for functions whose optimized_mir does not contain any calls or asserts. I plan to study adjusting the cost model later, but for now the compile time implications of this change are so significant that I think this very crude heuristic is well worth landing.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2023
Automatically enable cross-crate inlining for small functions This is basically reviving rust-lang#70550 The `#[inline]` attribute can have a significant impact on code generation or runtime performance (because it enables inlining between CGUs where it would normally not happen) and also on compile-time performance (because it enables MIR inlining). But it has to be added manually, which is awkward. This PR factors whether a DefId is cross-crate inlinable into a query, and replaces all uses of `CodegenFnAttrs::requests_inline` with this new query. The new query incorporates all the other logic that is used to determine whether a Def should be treated as cross-crate-inlinable, and as a last step inspects the function's optimized_mir to determine if it should be treated as cross-crate-inlinable. The heuristic implemented here is deliberately conservative; we only infer inlinability for functions whose optimized_mir does not contain any calls or asserts. I plan to study adjusting the cost model later, but for now the compile time implications of this change are so significant that I think this very crude heuristic is well worth landing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost