Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update clippy from 70b93aab to e170c849 #70574

Merged
merged 1 commit into from
Mar 30, 2020
Merged

submodules: update clippy from 70b93aab to e170c849 #70574

merged 1 commit into from
Mar 30, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

rustup  https://github.com/rust-lang/rust/pull/70536
Rustup to https://github.com/rust-lang/rust/pull/70449
readme: move "how to run single lint" instructions to "Allowing/denying lints" section.
git attribute macros not allowed in submodules
Deprecate REPLACE_CONSTS lint
Bump itertools

Fixes #70554

@matthiaskrgr
submodules: update clippy from 70b93aa to e170c84
eef8e48 
Changes:
````
rustup  rust-lang#70536
Rustup to rust-lang#70449
readme: move "how to run single lint" instructions to "Allowing/denying lints" section.
git attribute macros not allowed in submodules
Deprecate REPLACE_CONSTS lint
Bump itertools
````

Fixes rust-lang#70554
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020
@matthiaskrgr
Copy link
Member Author

r? @Dylan-DPC or @Centril

@Centril
Copy link
Contributor

Centril commented Mar 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2020

📌 Commit eef8e48 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2020
@Dylan-DPC-zz
Copy link

@bors p=1 rollup=never

@bors
Copy link
Contributor

bors commented Mar 30, 2020

⌛ Testing commit eef8e48 with merge 2113659...

@bors
Copy link
Contributor

bors commented Mar 30, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 2113659 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2020
@bors bors merged commit 2113659 into rust-lang:master Mar 30, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #70574!

Tested on commit 2113659.
Direct link to PR: #70574

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 30, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#70574!
aa4fcf7 
Tested on commit rust-lang/rust@2113659.
Direct link to PR: <rust-lang/rust#70574>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch April 5, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#70449
6 participants
@matthiaskrgr @rust-highfive @Centril @bors @Dylan-DPC-zz @nikomatsakis