Enable rust-lld on dist-x86_64-musl #70619
Conversation
Add rust-lld to llvm-tools-preview on nightly for musl
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@mati865 I see you did many changes to this file. My change is very simple. Could you review it or let me know who I should ask? |
|
No objections, I had even thought LLD is available in musl toochain already. This was asked on Zulip last week but nobody answered. |
Thanks for the feedback |
|
Hi @pietroalbini, sorry to bother you, I tried to find a overlap between people who might be reviewer and have worked the docker-ci and you turned up. Could review it? Or who should I ask? |
|
Thanks for this PR! @Mark-Simulacrum is the best person to review the PR, let's wait for their insights. |
|
I may be the best person but I also don't know what we have as a policy here. Having thought a bit more about this over the past week or so though I'm inclined to just approve (since it's a -preview component and one we're unlikely to stabilize as is). In the worst case we can just revert, it's a one line patch after all :) @bors r+ |
|
📌 Commit a61a7c5 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a61a7c5 with merge 09dcdc5ff7286270196d6cb0977490390571bde2... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
Seems spurious. @bors retry |
bors
added
S-waiting-on-bors
|
@pietroalbini |
|
☀️ Test successful - checks-azure |
|
I updated nightly and tested the wasm workflow on musl-distro: rust-lld works 👍 Currently the rustup-update has to be forced, because not all components are built. |
ghost
mentioned this pull request
…crum Enable docs on dist-x86_64-musl Add the `rust-docs` component to toolchain `x86_64-unknown-linux-musl`, which allows people using rustup on their musl-based linux distribution to download the rust-docs. `--disable-docs` is based on the assumption that `x86_64-unknown-linux-musl` is only a cross-compile target. I have tested that the docs are built. I assume the build-system will automatically detect the docs and create a `rust-docs` component. I will [monitor](https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-musl.html) the components and create a follow-up PR, if the docs aren't published. See also rust-lang#70619, where we enabled `rust-lld` to enable the wasm-workflow on musl-based linux distributions.
Add rust-lld to rustup llvm-tools-preview on nightly for musl
I am using a musl distro on my workstation, with
RUSTFLAGS="-C target-feature=-crt-static"this works fine. I know thatx86_64-unknown-linux-muslwas originally only meant as a target and not as a host. But most problems have been fixed, and I have fewer problems withunknown(rustup) than when I am usingx86_64-alpine-linux-musl(rust installed by the distro). The only thing I am missing is rust-lld in llvm-tools-preview on nightly.I needed rust-lld for a wasm tutorial. I built rust-lld and tested it with that tutorial, and it worked well. I asked here where to request to enable lld and ended up doing this PR.
I compared llvm-tools-preview
nightly-x86_64-unknown-linux-muslandnightly-x86_64-unknown-linux-gnu: only rust-lld is missing in musl.I tested the change using:
And I checked that the resulting rust-lld binary runs.