-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_target::abi: add Primitive variant to FieldsShape. #70629
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #70692) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@anyska well that is interesting, could you make it print the Oh, I think I have an idea... since uninhabited enums still share the layout with |
This comment has been minimized.
This comment has been minimized.
rustc_target::abi: add Primitive variant to FieldsShape. Originally suggested by @eddyb.
Could this have caused #70966 (comment)? |
@bors rollup=never (I can't see why this PR would do this but it's the only one in the rollup that should impact an assert like that) |
rustc_target::abi: add Primitive variant to FieldsShape. Originally suggested by @eddyb.
@bors p=1 |
⌛ Testing commit 15f8d89 with merge 2922f29bbcdde10237e4e2060c1326958a68af23... |
💔 Test failed - checks-azure |
Yes this is definitely causing that ICE, at least on targets mips64-unknown-linux-gnuabi64, mips64el-unknown-linux-gnuabi64.
|
@bors r=oli-obk |
📌 Commit 8f081d5 has been approved by |
☀️ Test successful - checks-azure |
Tested on commit rust-lang/rust@b2c1a60. Direct link to PR: <rust-lang/rust#70629> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
Originally suggested by @eddyb.