Improve scrollbar display in rustdoc #70656
Conversation
|
I think this looks reasonable, and it wouldn't hurt to improve the other scrollbars in the pages too. r=me when you decide either way. |
|
I'll make them a bit larger by default then. |
GuillaumeGomez
force-pushed
the
scrollbar-display
branch
from
ba9e269
to
cbee6c5
Compare
|
I extended the changes to all other scrollbars (there is actually just another one but just in case...). It looks like this now: webkit-based:
firefox:
If it looks ok to you @kinnison, then please r+. :) |
JohnTitor
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit cbee6c5 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - rust-lang#70656 (Improve scrollbar display in rustdoc) - rust-lang#71051 (Suggest .into() over try_into() when it would work) - rust-lang#71087 (Remove `FnCtxt::impl_self_ty`) - rust-lang#71097 (Pattern docs) - rust-lang#71101 (Miri: let machine hook dynamically decide about alignment checks) Failed merges: r? @ghost
|
I rather dislike this change and I'm considering opening an issue about it. I think the stylistic consistency between scroll bars in Firefox and other (gtk+) apps is important, and unfortunately changing their color completely changes their look. Also I can't find another example of a website with a dark mode that changes my scrollbar like this. For example, Stack Overflow and YouTube don't |
|
This makes the scrollbars look significantly worse and very distracting on my system as well. Here are some screenshots:
The new scrollbar for the main content is unexpectedly thick. It also stands out more than usual. I think this change should be either backed out or adjusted. (The reason I only notice this now is because https://phabricator.services.mozilla.com/D78400 finally got to me) |
|
@nagisa: We had issues because of the different handlings of the sidebars depending on the system so I'd prefer improvement over reverting. |
The scrollbar of the left sidebar in rustdoc looks very bad on firefox (on dark theme). This PR improves it:
With light theme:
And on chrome:
Small extra question: should I extend it to all scrollbars? I think it'd be better but just in case...
r? @kinnison