add STILL_FURTHER_SPECIALIZABLE flag
#70658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 1, 2020
Merged
eddyb
previously requested changes
Apr 1, 2020
There was a problem hiding this comment.
r=me after taking out the closure/generator changes, and replacing the comment. cc @nikomatsakis
davidtwco
force-pushed
the
issue-70285-still-further-specializable
branch
from
b99a903 to
9ef60be
Compare
|
@bors r+ |
|
📌 Commit 9ef60be001165a3c7e23ba3015ed82e25990d38a has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
This was referenced Apr 1, 2020
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
davidtwco
force-pushed
the
issue-70285-still-further-specializable
branch
from
9ef60be to
3daff36
Compare
eddyb
reviewed
Apr 2, 2020
This commit adds a STILL_FURTHER_SPECIALIZABLE flag to `TypeFlags` which replaces `needs_infer` and `needs_subst` in `Instance::resolve` and `assemble_candidates_from_impls.` Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
issue-70285-still-further-specializable
branch
from
3daff36 to
c665eae
Compare
|
@bors r+ |
|
📌 Commit c665eae has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 2, 2020
…-specializable, r=eddyb add `STILL_FURTHER_SPECIALIZABLE` flag Contributes to rust-lang#70285. This PR adds a `STILL_FURTHER_SPECIALIZABLE` flag to `TypeFlags` which replaces `needs_infer` and `needs_subst` in `Instance::resolve` and `assemble_candidates_from_impls`. r? @eddyb
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#70281 (Implement Hash for Infallible) - rust-lang#70421 (parse: recover on `const fn()` / `async fn()`) - rust-lang#70615 (Renamed `PerDefTables` to `Tables`) - rust-lang#70631 (Update cargo) - rust-lang#70634 (Remove some reexports in `rustc_middle`) - rust-lang#70658 (add `STILL_FURTHER_SPECIALIZABLE` flag) - rust-lang#70678 (Add missing markdown rust annotation) - rust-lang#70681 (Handle unterminated raw strings with no #s properly) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #70285.
This PR adds a
STILL_FURTHER_SPECIALIZABLEflag toTypeFlagswhich replaces
needs_inferandneeds_substinInstance::resolveand
assemble_candidates_from_impls.r? @eddyb