-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macro_rules: NtLifetime
cannot start with an identifier
#70768
Conversation
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
|
@mark-i-m |
Ah, I didn't realize that there was a distinct lifetime token. I thought we just used an apostrophe token followed by ident. In that case, this PR LGTM. |
📌 Commit 106b30e has been approved by |
Rollup of 6 pull requests Successful merges: - rust-lang#70635 (rustc_target: Some cleanup to `no_default_libraries`) - rust-lang#70748 (Do not disable field reordering on enums with big discriminant) - rust-lang#70752 (Add slice::fill) - rust-lang#70766 (use ManuallyDrop instead of forget inside collections) - rust-lang#70768 (macro_rules: `NtLifetime` cannot start with an identifier) - rust-lang#70783 (comment refers to removed type) Failed merges: r? @ghost
Discussed in T-compiler meeting. beta-accepted. |
…ulacrum [beta] backports This includes: * Do not reuse post LTO products when exports change rust-lang#71131 * macro_rules: `NtLifetime` cannot start with an identifier rust-lang#70768 * Update RELEASES.md for 1.43.0 rust-lang#70354 r? @ghost
Fixes #70446