Use smaller span for suggestion restricting lifetime #70827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
One could conceivably argue that the span should point to "the opaque type" mentioned in the error message instead of "the bound", but I think this PR is strictly an improvement. @bors r+ rollup |
|
📌 Commit 0664b81 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70519 (Tweak output of type params and constraints in the wrong order) - rust-lang#70704 (Make panic unwind the default for aarch64-*-windows-msvc targets) - rust-lang#70713 (Prefer sysroot from rustc in same directory as rust-gdb) - rust-lang#70739 (def_collector, visit_fn: account for no body) - rust-lang#70827 (Use smaller span for suggestion restricting lifetime) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.