-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Ord bound that was plaguing drain_filter #70843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 6, 2020
5 tasks
@bors r+ |
📌 Commit 6ee7e8c has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 7, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 7, 2020
…, r=Amanieu Remove the Ord bound that was plaguing drain_filter Now that rust-lang#70795 made it superfluous. Also removes superfluous lifetime specifiers (at least I think they are).
⌛ Testing commit 6ee7e8c with merge fe93565d1bf67895f48679cc53a782b1f99d43a2... |
@bors treeclosed=1000 mingw builders on Azure are having issues |
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Apr 7, 2020
@bors retry |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 10, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#70784 (Consider methods on fundamental `impl` when method is not found on numeric type) - rust-lang#70843 (Remove the Ord bound that was plaguing drain_filter) - rust-lang#70913 (Replace "rc"/"arc" lang items with Rc/Arc diagnostic items.) - rust-lang#70932 (De-abuse TyKind::Error in pattern type checking) - rust-lang#70952 (Clean up E0511 explanation) - rust-lang#70964 (rustc_session CLI lint parsing: mark a temporary hack as such) - rust-lang#70969 (Fix JSON file_name documentation for macros.) - rust-lang#70975 (Fix internal doc comment nits.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #70795 made it superfluous. Also removes superfluous lifetime specifiers (at least I think they are).