Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM submodule fixing sanitizers build with glibc 2.31 #70893

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Update LLVM submodule fixing sanitizers build with glibc 2.31 #70893

merged 1 commit into from
Apr 14, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Apr 7, 2020

Fixes #69556.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2020
@cuviper
Copy link
Member

cuviper commented Apr 7, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2020

📌 Commit ebd0267 has been approved by cuviper

@bors
Copy link
Contributor

bors commented Apr 7, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2020
@bors
Copy link
Contributor

bors commented Apr 13, 2020

⌛ Testing commit ebd0267 with merge 562d9c05a5cc153de5e3fdaf39ffa0e598570c9a...

@bors
Copy link
Contributor

bors commented Apr 13, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2020
@tmiasko
Copy link
Contributor Author

tmiasko commented Apr 13, 2020 •
edited
Loading

The failure looks completely unrelated to changes here. I opened a bug report #71099.

@cuviper
Copy link
Member

cuviper commented Apr 14, 2020

OK, we can try again...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2020
@bors
Copy link
Contributor

bors commented Apr 14, 2020

⌛ Testing commit ebd0267 with merge ba72b15...

@bors
Copy link
Contributor

bors commented Apr 14, 2020

☀️ Test successful - checks-azure
Approved by: cuviper
Pushing ba72b15 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2020
@bors bors merged commit ba72b15 into rust-lang:master Apr 14, 2020
@tmiasko tmiasko deleted the llvm-sanitizers branch April 14, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sanitizers=true fails to build
4 participants
@tmiasko @rust-highfive @cuviper @bors