-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] ty/layout: compute both niche-filling and tagged layouts for enums. #71045
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 13c200a with merge 9a594eaf4326233bc29fe01ece3e52c2a0406229... |
☀️ Try build successful - checks-azure |
Queued 9a594eaf4326233bc29fe01ece3e52c2a0406229 with parent e82734e, future comparison URL. |
Finished benchmarking try commit 9a594eaf4326233bc29fe01ece3e52c2a0406229, comparison URL. |
There doesn't seem to be any perf difference between master and this PR. |
r? @RalfJung |
I'm afraid I don't know this code nearly well enough to do reviews. I'd have suggested @eddyb until I saw they are the PR author. ;) |
This is only for the perf test 📈. If we did land this, we'd add a comparison between the two layouts, and pick the one that has smaller size, or more invalid values in the |
@rustbot modify labels to +S-waiting-on-review -S-waiting-on-author |
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
Thanks to @erikdesjardins, this was finished as #74069. |
Original message: Rollup merge of rust-lang#74069 - erikdesjardins:bad-niche, r=nikomatsakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
This is something I've wanted to do for a while, since if we can get away with it perf-wise, it should allow us to always pick the better of the two, even when the conditions would be otherwise subtle.