Skip to content

Remove usage of DUMMY_HIR_ID in CheckLoopVisitor #71071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove usage of DUMMY_HIR_ID in CheckLoopVisitor #71071

wants to merge 1 commit into from

Conversation

marmeladema
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2020
@marmeladema
Copy link
Contributor Author

cc @eddyb

@eddyb
Copy link
Member

eddyb commented Apr 12, 2020

Since this is so tiny, it might be worth moving the commit to #71069 and closing it (once GHA PR CI clears it in 5-10min).

@marmeladema
Copy link
Contributor Author

Closing in favor of #71069

@marmeladema marmeladema deleted the dummy-hir-id-check-loop-visitor branch April 12, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@davidtwco davidtwco

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marmeladema @rust-highfive @eddyb @davidtwco