Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some regression tests #71182

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Add some regression tests #71182

merged 5 commits into from
Apr 17, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Apr 16, 2020 •
edited
Loading

Closes #24843
Closes #28575
Closes #54067
Closes #66868
Closes #67893
Closes #68813

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Apr 16, 2020

📌 Commit 61ed813 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#71182 - JohnTitor:regression-tests, r=Mark-…
40df0b9 
…Simulacrum

Add some regression tests

Closes rust-lang#24843
Closes rust-lang#28575
Closes rust-lang#54067
Closes rust-lang#67893
Closes rust-lang#68813

I'm not sure who's the best person to ask to review since Centril is taking a break now.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#71182 - JohnTitor:regression-tests, r=Mark-…
c3c96eb 
…Simulacrum

Add some regression tests

Closes rust-lang#24843
Closes rust-lang#28575
Closes rust-lang#54067
Closes rust-lang#67893
Closes rust-lang#68813

I'm not sure who's the best person to ask to review since Centril is taking a break now.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 16, 2020
Closed
@Dylan-DPC-zz
Copy link

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2020
@JohnTitor
Copy link
Member Author

JohnTitor commented Apr 16, 2020 •
edited
Loading

I think the cause is the same as #67543 (comment), I'll figure out the targets that should be skipped for now.

@JohnTitor
Copy link
Member Author

JohnTitor commented Apr 16, 2020 •
edited
Loading

@Mark-Simulacrum So, adding dont-check-compiler-stderr and FIXME comment is enough for now? If so, I'd open another issue so that we can follow-up later.

@Mark-Simulacrum
Copy link
Member

Ah yeah let's go with that for now

@JohnTitor JohnTitor mentioned this pull request Apr 16, 2020
Closed
@JohnTitor
Copy link
Member Author

Addressed it with a6855b9 and opened #71222 to follow-up. Also added #66868 to the issue list since the cause is the same.
@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 16, 2020

📌 Commit a6855b9 has been approved by Mark-Simulacrum

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2020
@bors
Auto merge of rust-lang#71230 - Dylan-DPC:rollup-rofigbv, r=Dylan-DPC
861996e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70578 (Add long error explanation for E0657)
 - rust-lang#70910 (Hides default fns inside Fuse impl to avoid exposing it to any crate)
 - rust-lang#71164 (reword Miri validity errors: undefined -> uninitialized)
 - rust-lang#71182 (Add some regression tests)
 - rust-lang#71206 (Miri error messages: avoid try terminology)
 - rust-lang#71220 (Dogfood or_patterns in the standard library)
 - rust-lang#71225 (Fix typo in Default trait docs: Provides -> Provide)

Failed merges:

r? @ghost
@bors bors merged commit b347097 into rust-lang:master Apr 17, 2020
@JohnTitor JohnTitor deleted the regression-tests branch April 17, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
6 participants
@JohnTitor @rust-highfive @Mark-Simulacrum @bors @Dylan-DPC-zz @nikomatsakis