-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit basic block info for stmts and terminators in MIR dumps only with -Zverbose #71200
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
...test/mir-opt/array-index-is-temporary/32bit/rustc.main.SimplifyCfg-elaborate-drops.after.mir
Outdated
Show resolved
Hide resolved
☔ The latest upstream changes (presumably #70755) made this pull request unmergeable. Please resolve the merge conflicts. |
df6c552
to
05acdea
Compare
- return; // bb2[2]: scope 0 at $DIR/const-promotion-extern-static.rs:9:1: 9:45 | ||
+ return; // bb2[0]: scope 0 at $DIR/const-promotion-extern-static.rs:9:1: 9:45 | ||
- StorageDead(_5); // scope 0 at $DIR/const-promotion-extern-static.rs:9:43: 9:44 | ||
- StorageDead(_3); // scope 0 at $DIR/const-promotion-extern-static.rs:9:43: 9:44 | ||
return; // scope 0 at $DIR/const-promotion-extern-static.rs:9:1: 9:45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice example of how this PR cleans up the .diff
mir-opt test files.
☔ The latest upstream changes (presumably #71549) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, this is great! It doesn't even affect the (two) NLL tests, as they use -Zverbose
already, which is even better!
@bors r=eddyb p=1 (bitrotty) |
📌 Commit a2fdc94 has been approved by |
☀️ Test successful - checks-azure |
r? @eddyb
as per #70755 (comment)