Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outlives: ignore lifetimes shallowly found in ty::FnDefs. #71218

Merged
merged 1 commit into from
Apr 18, 2020
Merged

outlives: ignore lifetimes shallowly found in ty::FnDefs. #71218

merged 1 commit into from
Apr 18, 2020
+64 −6

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Apr 16, 2020 •
edited
Loading

Fixes #70917 by restoring the pre-#70164 behavior for now.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020
@eddyb
Copy link
Member Author

eddyb commented Apr 16, 2020

@bors try

@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Trying commit f86f032 with merge a571be2b074730b31d0bb62a6984dde8e1f57278...

@eddyb eddyb mentioned this pull request Apr 16, 2020
Closed
@bors
Copy link
Contributor

bors commented Apr 16, 2020

☀️ Try build successful - checks-azure
Build commit: a571be2b074730b31d0bb62a6984dde8e1f57278 (a571be2b074730b31d0bb62a6984dde8e1f57278)

@eddyb
Copy link
Member Author

eddyb commented Apr 16, 2020

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-70917/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-71218 created and queued.
🤖 Automatically detected try build a571be2b074730b31d0bb62a6984dde8e1f57278
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2020
@eddyb eddyb marked this pull request as ready for review April 16, 2020 23:25
@craterbot
Copy link
Collaborator

🚧 Experiment pr-71218 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-71218 is completed!
📊 0 regressed and 121 fixed (194 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 18, 2020
@eddyb
Copy link
Member Author

eddyb commented Apr 18, 2020

So it's 121 fixed + 67 unchanged because the newly published version of proptest fixed 67 out of 188 regressions, and this is much easier to see because we reran crater on the list of regressed crates.

@bors p=10 rollup=never (this is a regression fix that needs to get in before beta branches off)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 18, 2020

📌 Commit f86f032 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2020
@bors
Copy link
Contributor

bors commented Apr 18, 2020

⌛ Testing commit f86f032 with merge 52fa23a...

@bors
Copy link
Contributor

bors commented Apr 18, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 52fa23a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2020
@bors bors merged commit 52fa23a into rust-lang:master Apr 18, 2020
@eddyb eddyb deleted the a-lifetime-stranded-in-fn-def branch April 27, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile regression "cannot infer an appropriate lifetime for lifetime parameter"
5 participants
@eddyb @bors @craterbot @nikomatsakis @rust-highfive