Skip to content

Account for use of try!() in 2018 edition and guide users in the right direction #71243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2020
Merged

Account for use of try!() in 2018 edition and guide users in the right direction #71243

merged 4 commits into from
Apr 18, 2020

Conversation

Duddino
Copy link

@Duddino Duddino commented Apr 17, 2020

fixes #71155

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020
@Duddino
Copy link
Author

Duddino commented Apr 17, 2020

I'm not sure how this works, should I pick @estebank since he opened the issue?

@Dylan-DPC-zz
Copy link

r? @estebank

@petrochenkov petrochenkov self-assigned this Apr 17, 2020
estebank
estebank reviewed Apr 17, 2020
View reviewed changes
@Duddino Duddino requested a review from estebank April 17, 2020 16:27
estebank
estebank approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good!

I left some nitpicks.

estebank
estebank reviewed Apr 17, 2020
View reviewed changes
estebank
estebank reviewed Apr 17, 2020
View reviewed changes
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 17, 2020

📌 Commit 79abac8 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2020
@petrochenkov petrochenkov removed their assignment Apr 17, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2020
@bors
Auto merge of rust-lang#71264 - Dylan-DPC:rollup-njgbey7, r=Dylan-DPC
cff9a75 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70467 (Use `call` instead of `invoke` for functions that cannot unwind )
 - rust-lang#71070 (rustbuild: Remove stage 0 LLD flavor workaround for MSVC)
 - rust-lang#71167 (big-O notation: parenthesis for function calls, explicit multiplication)
 - rust-lang#71238 (Miri: fix typo)
 - rust-lang#71242 (Format Mailmap To Work With GitHub)
 - rust-lang#71243 (Account for use of `try!()` in 2018 edition and guide users in the right direction)

Failed merges:

r? @ghost
@bors bors merged commit 4b9eeca into rust-lang:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Account for use of try!() in 2018 edition and guide users in the right direction

7 participants

@Duddino @rust-highfive @Dylan-DPC-zz @estebank @bors @petrochenkov @ecstatic-morse