Fix some tests failing in --pass check mode
#71324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Apr 19, 2020
| // build-pass | ||
| // ignore-pass (emit codegen-time warnings and verify that they are indeed warnings and not errors) |
There was a problem hiding this comment.
Did you mean "emits" and "verifies"? I cannot entirely parse this comment.
There was a problem hiding this comment.
I copypasted it from other tests.
"[Let the test] emit codegen-time warnings and verify that they are indeed warnings and not errors.", I guess.
There was a problem hiding this comment.
Okay. I'd still prefer if you could clarify here, I found it unclear if this was asking the reader to do something or the compiler or what.
petrochenkov
force-pushed
the
passcheck2
branch
from
d1e400a to
1c77e20
Compare
|
Thanks! |
|
📌 Commit 1c77e20 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#71026 (Fix false "never constructed" warnings for `Self::` variant paths) - rust-lang#71310 (Do not show DefId in diagnostics) - rust-lang#71317 (miri-unleash test for llvm_asm) - rust-lang#71324 (Fix some tests failing in `--pass check` mode) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung