-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error code explanation extra check #71350
Error code explanation extra check #71350
Conversation
a80dba8
to
28a9725
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
28a9725
to
a447640
Compare
CI passed. |
trait Index<Idx> { /* ... */ } | ||
|
||
foo(true); // `bool` does not implement `Index<u8>` | ||
#[rustc_on_unimplemented = "error on `{Self}` with params `<{A},{B}>`"] // error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is a major change to the previous one and doesn't reflect what the text around it says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll need to be updated I guess. But before, it wasn't throwing the correct error code.
a447640
to
d8402bd
Compare
|
||
foo(true); // `bool` does not implement `Index<u8>` | ||
#[rustc_on_unimplemented(lorem="")] // error! | ||
trait BadAnnotation {} | ||
``` | ||
|
||
there will be an error about `bool` not implementing `Index<u8>`, followed by a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still has the wrong explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it has to be fixed in another PR. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, can you open an issue about it?
@@ -15,21 +15,58 @@ const WHITELIST: &[&str] = &[ | |||
"E0727", "E0729", | |||
]; | |||
|
|||
// Some error codes don't have any tests apparently... | |||
const IGNORE_EXPLANATION_CHECK: &[&str] = &[ | |||
"E0570", "E0601", "E0602", "E0639", "E0729", "E0749", "E0750", "E0751", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an issue with a list of these error codes and the goal to remove this constant
CI failed, though I'm not sure what's wrong, there's little information. Maybe spurious @bors r+ |
📌 Commit d8402bd6cd00d9a1d05b592ed45a986a65a980fb has been approved by |
…rror code and also that 'compile_fail' isn't mispelled
d8402bd
to
5cdea2d
Compare
@bors r+ |
📌 Commit 5cdea2d has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#71256 (Lint must_use on mem::replace) - rust-lang#71350 (Error code explanation extra check) - rust-lang#71369 (allow wasm32 compilation of librustc_data_structures/profiling.rs) - rust-lang#71400 (proc_macro::is_available()) - rust-lang#71440 (Implement `Copy` for `AllocErr`) Failed merges: r? @ghost
r? @Mark-Simulacrum