Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Switch to dev-static bootstrap #71378

Merged
merged 3 commits into from
Apr 21, 2020
Merged

[beta] Switch to dev-static bootstrap #71378

merged 3 commits into from
Apr 21, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Apr 21, 2020 •
edited
Loading

Finishes master to beta promotion.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=100 rollup=never

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

📌 Commit 8984aaf has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2020
@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 8984aaf with merge 0bf01bf8b49a0d8550dc531f83839592b4b10eaa...

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2020
@Mark-Simulacrum
Always permit miri to fail to build
15a102b 
This presumably "accidentally" never actually got triggered in the past, but
since we don't actually require shipping miri on beta or stable, this should be
fine.
@Mark-Simulacrum
Copy link
Member Author

@bors r+

I've pushed up a commit that should let miri not build on the dist builders. I'm unclear why this wasn't a problem before now, but possibly we just happened to always have miri building...

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

📌 Commit 15a102b has been approved by Mark-Simulacrum

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 21, 2020

📌 Commit 15a102b has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 15a102b with merge 6595210c5ded112ef095481270517cae5c364248...

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

💔 Test failed - checks-azure

@Mark-Simulacrum
Copy link
Member Author

@bors retry GitHub down?

@Dylan-DPC-zz
Copy link

@bors retry

bors didn't fire last time

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020
@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 15a102b with merge f40d054dab59b115d9d4d779f95d1e2981e66431...

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2020
@Mark-Simulacrum
Copy link
Member Author

cc @topecongiro I've pushed up a rust-1.44.0-beta branch to the rustfmt repository and cherry-picked the test fixes onto it. It would be great to get that into rust-lang/rust's master rustfmt; we've had to apply this patch for a number of beta releases at this point. Let me know if I can help do that.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

📌 Commit 59ced7b has been approved by Mark-Simulacrum

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2020
@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 59ced7b with merge a7d891e...

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing a7d891e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2020
@bors bors merged commit a7d891e into rust-lang:beta Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @bors @Dylan-DPC-zz @RalfJung