Don't fuse Chain in its second iterator #71404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the "first" iterator is actually set `None` when exhausted, depending on whether you iterate forward or backward. This restores behavior similar to the former `ChainState`, where it would transition from `Both` to `Front`/`Back` and only continue from that side. However, if you mix directions, then this may still set both sides to `None`, totally fusing the iterator.
rust-highfive
added
the
S-waiting-on-review
|
I like this. Certainly seems justifiable to "don't write a @bors r+ I see this is marked as a beta regression; what's the process for contemplating that? |
|
📌 Commit eeb687f has been approved by |
bors
added
S-waiting-on-bors
scottmcm
added
the
beta-nominated
cuviper
added
I-nominated
T-libs-api
Needs |
|
Cc @rust-lang/libs on backport approval |
|
Looks okay to backport. Is this regressed in 1.43 or 1.44? #71375 only says it worked in 1.42 and is broken in nightly (1.44). |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70633 (Confusing suggestion on incorrect closing `}`) - rust-lang#71404 (Don't fuse Chain in its second iterator) - rust-lang#71408 (Check code blocks tags) - rust-lang#71442 (Add a "by reference" adaptor for `AllocRef`) - rust-lang#71446 (Only use read_unaligned in transmute_copy if necessary) - rust-lang#71470 (Fix doc links) - rust-lang#71479 (add back Scalar::null_ptr) Failed merges: r? @ghost
Mark-Simulacrum
added
the
beta-accepted
|
Accepting for beta backport per #71404 (comment) |
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2020
…ulacrum [beta] backports This backport rollup includes the following: * [beta] Update cargo rust-lang#71967 * Backport 1.43.1 release notes to master rust-lang#71914 * Update the `cc` crate rust-lang#71882 * resolve: Relax fresh binding disambiguation slightly to fix regression rust-lang#71846 * Do not try to find binop method on RHS `TyErr` rust-lang#71810 * Quick and dirty fix of the unused_braces lint rust-lang#71517 * Update stdarch submodule rust-lang#71495 * normalize field projection ty to fix broken MIR issue rust-lang#71488 * Update openssl-src to 1.1.1g rust-lang#71430 * fix error code in E0751.md rust-lang#71426 * Don't fuse Chain in its second iterator rust-lang#71404 * Remove some `Vec` allocations to improve performance rust-lang#71268 * [CI] Use the latest Python available on Windows rust-lang#71995 It also switches the bootstrap compiler to 1.43.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the "first" iterator is actually set
Nonewhen exhausted,depending on whether you iterate forward or backward. This restores
behavior similar to the former
ChainState, where it would transitionfrom
BothtoFront/Backand only continue from that side.However, if you mix directions, then this may still set both sides to
None, totally fusing the iterator.Fixes #71375
r? @scottmcm