Update Error 0432 long description for Rust 2018 #71413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples and reasoning in the long description were for Rust 2015 and are unnecessary or wrong in Rust 2018.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
|
||
| ``` | ||
| use core::any; // No extern crate required in Rust 2018! | ||
| # fn main() {} |
|
|
||
| In Rust 2018, the `extern crate` declaration is not required and you can instead just `use` it: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
You'll need to add edition2018 to make it work I think.
|
|
||
| In Rust 2018, paths in `use` statements are relative to the current module unless they begin with the name of a crate or a literal `crate::`, in which case they start from the crate root. As in Rust 2015 code, the `self::` and `super::` prefixes refer to the current and parent modules. | ||
|
|
||
| Also verify that you didn't misspell the import |
There was a problem hiding this comment.
You can fill the line more you know. :)
joelpalmer
added
S-waiting-on-review
Dylan-DPC-zz
added
S-waiting-on-author
|
@BookOwl any updates? |
|
Closing due to inactivity. Feel free to reopen or open another PR if you want to restart working on this, thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2020
…GuillaumeGomez Update E0432 long description with the separate behaviors of editions 2015 and 2018 Fixes rust-lang#64668. I restarted from the work done in rust-lang#71413.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples and reasoning in the long description for Error code 0432 (unresolved import) were for Rust 2015 and are unnecessary or wrong in Rust 2018.
This PR resolves issue #64668.