Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak some suggestions in rustc_resolve #71438

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@petrochenkov
Copy link
Contributor

r=me after replacing "parenthesis" with "parentheses" in src/librustc_resolve/late/diagnostics.rs.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2020
@estebank estebank force-pushed the resolve-sugg-tiny branch from bc51ab0 to 6e3ba6f Compare April 26, 2020 18:44
@estebank
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Apr 26, 2020

📌 Commit 6e3ba6f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#68716 (Stabilize `Span::mixed_site`)
 - rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader)
 - rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`)
 - rust-lang#71419 (add message for resolution failure because wrong namespace)
 - rust-lang#71438 (Tweak some suggestions in `rustc_resolve`)
 - rust-lang#71589 (remove Unique::from for shared pointer types)

Failed merges:

r? @ghost
@bors bors merged commit ac62dce into rust-lang:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants