-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline some function docs in core::ptr
#71454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 23, 2020
ecstatic-morse
force-pushed
the
inline-core-ptr-docs
branch
from
April 23, 2020 01:01
9adaacc
to
b3c26de
Compare
r? @RalfJung |
ecstatic-morse
changed the title
Inline some functions docs in
Inline some functions docs in Apr 23, 2020
std::ptr
core::ptr
ecstatic-morse
changed the title
Inline some functions docs in
Inline some function docs in Apr 23, 2020
core::ptr
core::ptr
Oh that's great, we don't even have to duplicate anything. :) @bors r+ rollup |
📌 Commit b3c26de has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 23, 2020
@ecstatic-morse once this lands, could you submit a PR against the Nomicon to basically revert rust-lang/nomicon#165 ? |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 23, 2020
…, r=RalfJung Inline some function docs in `core::ptr` Resolves rust-lang#64539.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 23, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71005 (Reading from the return place is fine) - rust-lang#71198 (Const check/promotion cleanup and sanity assertion) - rust-lang#71396 (Improve E0308 error message wording again) - rust-lang#71452 (Remove outdated reference to interpreter snapshotting) - rust-lang#71454 (Inline some function docs in `core::ptr`) - rust-lang#71461 (Improve E0567 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64539.