Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline some function docs in core::ptr #71454

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ecstatic-morse
Copy link
Contributor

Resolves #64539.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2020
@joshtriplett
Copy link
Member

r? @RalfJung

@ecstatic-morse ecstatic-morse changed the title Inline some functions docs in std::ptr Inline some functions docs in core::ptr Apr 23, 2020
@ecstatic-morse ecstatic-morse changed the title Inline some functions docs in core::ptr Inline some function docs in core::ptr Apr 23, 2020
@RalfJung
Copy link
Member

Oh that's great, we don't even have to duplicate anything. :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 23, 2020

📌 Commit b3c26de has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
@RalfJung
Copy link
Member

@ecstatic-morse once this lands, could you submit a PR against the Nomicon to basically revert rust-lang/nomicon#165 ?

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 23, 2020
…, r=RalfJung

Inline some function docs in `core::ptr`

Resolves rust-lang#64539.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71005 (Reading from the return place is fine)
 - rust-lang#71198 (Const check/promotion cleanup and sanity assertion)
 - rust-lang#71396 (Improve E0308 error message wording again)
 - rust-lang#71452 (Remove outdated reference to interpreter snapshotting)
 - rust-lang#71454 (Inline some function docs in `core::ptr`)
 - rust-lang#71461 (Improve E0567 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 98cadb2 into rust-lang:master Apr 23, 2020
@ecstatic-morse ecstatic-morse deleted the inline-core-ptr-docs branch October 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: missing docs for core::ptr::{copy, copy_nonoverlapping, write_bytes}
5 participants