Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lib crate type for SGX in fn build_auxiliary #71456

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Use lib crate type for SGX in fn build_auxiliary #71456

merged 1 commit into from
Apr 28, 2020

Conversation

mzohreva
Copy link
Contributor

since SGX does not support dylib

cc @Goirad

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2020
@Goirad
Copy link
Contributor

Goirad commented Apr 23, 2020

This looks good to me

@mzohreva
Copy link
Contributor Author

cc @jethrogb

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 28, 2020

📌 Commit 7f13723 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 28, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2020
@bors
Auto merge of rust-lang#71644 - Dylan-DPC:rollup-cq7plwa, r=Dylan-DPC
db98d32 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71340 (Moving more build-pass tests to check-pass)
 - rust-lang#71456 (Use lib crate type for SGX in `fn build_auxiliary`)
 - rust-lang#71615 (share some common code for compile-time miri instances)
 - rust-lang#71637 (Minor formatting changes in `cfg-sanitize.md`)
 - rust-lang#71641 (Update books)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Apr 28, 2020

☔ The latest upstream changes (presumably #71644) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2020
@bors bors merged commit 45edd23 into rust-lang:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzohreva @rust-highfive @Goirad @nikomatsakis @bors