Inherit `#[stable(..)]` annotations in enum variants and fields from its item #71481

estebank · 2020-04-23T18:20:34Z

Lint changes for #65515. The stdlib will have to be updated once this lands in beta and that version is promoted in master.

rust-highfive · 2020-04-23T18:20:37Z

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2020-05-07T18:20:54Z

CC @rust-lang/compiler who might be interested in this.

petrochenkov · 2020-05-07T18:29:13Z

I still don't think this is a good idea.

petrochenkov · 2020-05-07T18:39:34Z

Items in trait impls don't currently require stability attributes.
This PR at least should use the same mechanism.

estebank · 2020-05-07T19:23:51Z

I still don't think this is a good idea.

Does this refer to this implementation, the general idea of stability stable attributes flowing down in general or the specific case of them flowing down from ADTs to their variants and fields?

From the first diff section in https://github.com/rust-lang/rust/pull/71481/files#diff-6bfe08b41853465a10867dc22a4a548c it seems to me that we originally intended this new behavior to be the correct one.

It's also making me realize that after landing this when we update the used beta in this repo we'll also need to in the same commit update the current usages, as having two different nested stable attributes with the same value in the feature field is denied by this PR (in currently existing code) and would require a more significant change.

Items in trait impls don't currently require stability attributes.
This PR at least should use the same mechanism.

The mechanism used for impls is a visitor boolean field. This PR adds an argument and can be changed to be a field, but I find using fields tracking current state harder to follow, at least when trying things out first. It should be easy to change it to use a field if necessary.

nagisa · 2020-06-06T12:44:08Z

src/test/ui/stability-attribute/stability-attribute-issue-43027.rs

 #![feature(staged_api)]
 #![stable(feature = "test", since = "0")]

 #[stable(feature = "test", since = "0")]
-pub struct Reverse<T>(pub T); //~ ERROR field has missing stability attribute
+pub struct Reverse<T>(pub T);


I feel like this is potentially dangerous change that also limits our options in the future.

I can see an use-case in adding an unstable new field to a struct and not impacting any stable uses of the struct.

Similarly for #[non_exhaustive] enums (the only kind of enum to which it is valid to add a variant), though perhaps significantly more debatable depending on the specific case.

I can see an use-case in adding an unstable new field to a struct and not impacting any stable uses of the struct.

I'm not sure I follow. This PR makes the linked code semantically the same as the current

#[stable(feature = "test", since = "0")] pub struct Reverse<T>(#[stable(feature = "test", since = "0")] pub T);

but you can still add unstable (and stable with different feature name) annotations to individual fields as you add to them. You currently get a compile error with the presented code. I don't see how this change limits us?

I guess the point is more that we might accidentally stabilize struct fields without intending to?

Yeah, the reason this comment ended up being here is because I’m expressing my observation based on the removed error message, not because the struct is in any way interesting.

@nikomatsakis summarized my point well.

Dylan-DPC-zz · 2020-06-30T08:28:45Z

@matthewjasper any updates on this?

nikomatsakis · 2020-06-30T17:49:29Z

I'm nominating to discuss in a triage meeting and decide next steps here.

spastorino · 2020-07-02T17:39:12Z

Removed I-nominated by mistake and re-added it again, we didn't have time to discuss this issue during this week triage meeting. So keeping it nominated for the next one.

spastorino · 2020-07-09T14:39:44Z

This was discussed in today's weekly meeting. Removing nomination.

bors · 2021-03-03T04:28:44Z

💥 Test timed out

rust-log-analyzer · 2021-03-03T05:48:29Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

estebank · 2021-03-03T23:14:39Z

@bors retry

…atsakis Inherit `#[stable(..)]` annotations in enum variants and fields from its item Lint changes for rust-lang#65515. The stdlib will have to be updated once this lands in beta and that version is promoted in master.

bors · 2021-03-04T04:11:12Z

⌛ Testing commit 49310ce with merge d81b0db9e9fc6a3ecbf3d00f9652e8c33aa953d7...

rust-log-analyzer · 2021-03-04T04:26:27Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Removing intermediate container befbf413490f
 ---> 0862050eff83
Step 5/10 : RUN npm install es-check -g
 ---> Running in 019c2ce940b3
/node-v14.4.0-linux-x64/bin/es-check -> /node-v14.4.0-linux-x64/lib/node_modules/es-check/index.js

> spawn-sync@1.0.15 postinstall /node-v14.4.0-linux-x64/lib/node_modules/es-check/node_modules/spawn-sync
> node postinstall
+ es-check@5.2.1
added 95 packages from 44 contributors in 3.844s
Removing intermediate container 019c2ce940b3
 ---> 85daf0875536
---
Cloning into 'rust-toolstate'...
<Nothing changed>
+ es-check es5 ../src/librustdoc/html/static/main.js ../src/librustdoc/html/static/settings.js ../src/librustdoc/html/static/source-script.js ../src/librustdoc/html/static/storage.js

Cannot read property 'includes' of undefined

bors · 2021-03-04T04:28:59Z

💔 Test failed - checks-actions

JohnTitor · 2021-03-04T06:44:18Z

Unrelated CI failure, @bors retry

…atsakis Inherit `#[stable(..)]` annotations in enum variants and fields from its item Lint changes for rust-lang#65515. The stdlib will have to be updated once this lands in beta and that version is promoted in master.

bors · 2021-03-05T05:28:11Z

⌛ Testing commit 49310ce with merge a0d66b5...

bors · 2021-03-05T08:32:57Z

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing a0d66b5 to master...

…stab, r=estebank Enum variant ctor inherits the stability of the enum variant Fixes rust-lang#100399 Fixes rust-lang#100420 Context rust-lang#71481 for why enum variants don't need stability

rust-highfive assigned matthewjasper Apr 23, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2020

estebank mentioned this pull request Apr 23, 2020

Remove inherited #[stable(..)] annotations #71482

Closed

This comment has been minimized.

Sign in to view

estebank force-pushed the inherit-stability branch from 06a9316 to 8b3c6ee Compare April 23, 2020 21:25

This comment has been minimized.

Sign in to view

estebank force-pushed the inherit-stability branch from 8b3c6ee to f7b8313 Compare April 23, 2020 23:18

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-stability Area: `#[stable]`, `#[unstable]` etc. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020

estebank mentioned this pull request May 5, 2020

Reduce the places where stable annotations are needed #65515

Open

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2020

This comment has been minimized.

Sign in to view

Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2020

nagisa reviewed Jun 6, 2020

View reviewed changes

nikomatsakis added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2020

spastorino added I-nominated and removed I-nominated labels Jul 2, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021

Dylan-DPC-zz mentioned this pull request Mar 4, 2021

Rollup of 11 pull requests #82737

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021

Dylan-DPC-zz mentioned this pull request Mar 5, 2021

Rollup of 9 pull requests #82785

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 5, 2021

bors merged commit a0d66b5 into rust-lang:master Mar 5, 2021

rustbot added this to the 1.52.0 milestone Mar 5, 2021

camelid mentioned this pull request Jul 23, 2021

Error on private items with stability attributes #83397

Closed

compiler-errors mentioned this pull request Aug 11, 2022

Enum variant ctor inherits the stability of the enum variant #100431

Merged

estebank deleted the inherit-stability branch November 9, 2023 05:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inherit `#[stable(..)]` annotations in enum variants and fields from its item #71481

Inherit `#[stable(..)]` annotations in enum variants and fields from its item #71481

estebank commented Apr 23, 2020

rust-highfive commented Apr 23, 2020

This comment has been minimized.

This comment has been minimized.

estebank commented May 7, 2020

petrochenkov commented May 7, 2020

petrochenkov commented May 7, 2020

estebank commented May 7, 2020 •

edited

Loading

This comment has been minimized.

nagisa Jun 6, 2020

estebank Jun 11, 2020

nikomatsakis Jun 12, 2020

nagisa Jun 12, 2020

Dylan-DPC-zz commented Jun 30, 2020

nikomatsakis commented Jun 30, 2020

spastorino commented Jul 2, 2020

spastorino commented Jul 9, 2020

bors commented Mar 3, 2021

rust-log-analyzer commented Mar 3, 2021

estebank commented Mar 3, 2021

bors commented Mar 4, 2021

rust-log-analyzer commented Mar 4, 2021

bors commented Mar 4, 2021

JohnTitor commented Mar 4, 2021

bors commented Mar 5, 2021

bors commented Mar 5, 2021

Inherit #[stable(..)] annotations in enum variants and fields from its item #71481

Inherit #[stable(..)] annotations in enum variants and fields from its item #71481

Conversation

estebank commented Apr 23, 2020

rust-highfive commented Apr 23, 2020

This comment has been minimized.

This comment has been minimized.

estebank commented May 7, 2020

petrochenkov commented May 7, 2020

petrochenkov commented May 7, 2020

estebank commented May 7, 2020 • edited Loading

This comment has been minimized.

nagisa Jun 6, 2020

Choose a reason for hiding this comment

estebank Jun 11, 2020

Choose a reason for hiding this comment

nikomatsakis Jun 12, 2020

Choose a reason for hiding this comment

nagisa Jun 12, 2020

Choose a reason for hiding this comment

Dylan-DPC-zz commented Jun 30, 2020

nikomatsakis commented Jun 30, 2020

spastorino commented Jul 2, 2020

spastorino commented Jul 9, 2020

bors commented Mar 3, 2021

rust-log-analyzer commented Mar 3, 2021

estebank commented Mar 3, 2021

bors commented Mar 4, 2021

rust-log-analyzer commented Mar 4, 2021

bors commented Mar 4, 2021

JohnTitor commented Mar 4, 2021

bors commented Mar 5, 2021

bors commented Mar 5, 2021

Inherit `#[stable(..)]` annotations in enum variants and fields from its item #71481

Inherit `#[stable(..)]` annotations in enum variants and fields from its item #71481

estebank commented May 7, 2020 •

edited

Loading