Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backtrace-sys crate to 0.1.36 #71577

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Apr 26, 2020

  • Fix an off-by-one error in backtrace-sys
  • Only explicitly configure debuginfo in rustc-dep-of-std

rust-lang/backtrace-rs@0.3.46...backtrace-sys-0.1.36

Fixes #71397.

* Fix an off-by-one error in backtrace-sys
* Only explicitly configure debuginfo in rustc-dep-of-std
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2020

📌 Commit f22dd92 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2020
Thomasdezeeuw added a commit to Thomasdezeeuw/stored that referenced this pull request Apr 28, 2020
Caused by a problem in libbacktrace first reported to rust repo in
rust-lang/rust#71397, than to backtrac-rs in
rust-lang/backtrace-rs#312, fixed in
backtrace-rs here:
rust-lang/backtrace-rs@b53c52b.

Update of backtrace-rs for rustc is here:
rust-lang/rust#71577, no yet merged.
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Apr 29, 2020

⌛ Testing commit f22dd92 with merge d9312a8...

@bors
Copy link
Contributor

bors commented Apr 29, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing d9312a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 29, 2020
@bors bors merged commit d9312a8 into rust-lang:master Apr 29, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71577!

Tested on commit d9312a8.
Direct link to PR: #71577

💔 rustc-dev-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 29, 2020
Tested on commit rust-lang/rust@d9312a8.
Direct link to PR: <rust-lang/rust#71577>

💔 rustc-dev-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
@tmiasko tmiasko deleted the backtrace-sys branch July 1, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUST_BACKTRACE on macOS can trigger crashes
5 participants