use new interface to create threads on HermitCore #71591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stlankes
commented
Apr 26, 2020
stlankes
commented
- the new interface allows to define the stack size
- increase the default stack size to 1 MByte
- the new interface allows to define the stack size
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Apr 27, 2020
src/libstd/sys/hermit/thread.rs
Outdated
| @@ -16,25 +16,24 @@ pub struct Thread { | |||
| unsafe impl Send for Thread {} | |||
| unsafe impl Sync for Thread {} | |||
|
|
|||
| pub const DEFAULT_MIN_STACK_SIZE: usize = 262144; | |||
| pub const DEFAULT_MIN_STACK_SIZE: usize = 1_048_576; | |||
There was a problem hiding this comment.
Suggested change
| pub const DEFAULT_MIN_STACK_SIZE: usize = 1_048_576; | |
| pub const DEFAULT_MIN_STACK_SIZE: usize = 1 << 20; |
There was a problem hiding this comment.
You are right. Ich changed the line.
joelpalmer
added
S-waiting-on-review
|
@hanna-kruppe waiting for your review on this :) |
|
@bors r+ |
|
📌 Commit 2c43746 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2020
…ruppe use new interface to create threads on HermitCore - the new interface allows to define the stack size - increase the default stack size to 1 MByte
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71269 (Define UB in float-to-int casts to saturate) - rust-lang#71591 (use new interface to create threads on HermitCore) - rust-lang#71819 (x.py: Give a more helpful error message if curl isn't installed) - rust-lang#71893 (Use the `impls` module to import pre-existing dataflow analyses) - rust-lang#71929 (Use -fvisibility=hidden for libunwind) - rust-lang#71937 (Ignore SGX on a few ui tests) - rust-lang#71944 (Add comment for `Ord` implementation for array) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.