Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use bash when executing the "bors build finished" jobs #71675

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

pietroalbini
Copy link
Member

We don't clone the repository in those builders, so the default shell (src/ci/exec-with-shell.py) is not present there. This fixes a GHA regression introduced in #71434.

r? @Mark-Simulacrum

We don't clone the repository in those builders, so the default shell
(src/ci/exec-with-shell.py) is not present there.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2020
@Mark-Simulacrum
Copy link
Member

I didn't even really know we had such jobs, but okay :)

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2020

📌 Commit fde5811 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2020
@pietroalbini
Copy link
Member Author

@bors p=5

This is blocking double-gating GHA and Azure Pipelines.

@bors
Copy link
Contributor

bors commented Apr 30, 2020

⌛ Testing commit fde5811 with merge be8589f...

@bors
Copy link
Contributor

bors commented Apr 30, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing be8589f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 30, 2020
@bors bors merged commit be8589f into rust-lang:master Apr 30, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71675!

Tested on commit be8589f.
Direct link to PR: #71675

🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 30, 2020
Tested on commit rust-lang/rust@be8589f.
Direct link to PR: <rust-lang/rust#71675>

🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
@pietroalbini pietroalbini deleted the ci-fix-shrink-regression branch December 23, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants