Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update cargo from 90931d9b3 to 258c89644 #71742

Merged
merged 1 commit into from
May 1, 2020
Merged

submodules: update cargo from 90931d9b3 to 258c89644 #71742

merged 1 commit into from
May 1, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

Remove unnecessary loop in `maybe_spurious`
Fix error with git repo discovery and symlinks.
Allow failure when setting file mtime.
Support multiple `--target` flags on the CLI
build-std: Don't treat std like a "local" package.
Allow `cargo package --list` even for things that don't package.

I'd like to get rust-lang/cargo#8186 into nightly asap. :)

r? @ehuss

@matthiaskrgr
submodules: update cargo from 90931d9b3 to 258c89644
868d559 
Changes:
````
Remove unnecessary loop in `maybe_spurious`
Fix error with git repo discovery and symlinks.
Allow failure when setting file mtime.
Support multiple `--target` flags on the CLI
build-std: Don't treat std like a "local" package.
Allow `cargo package --list` even for things that don't package.
````
@rust-highfive
Copy link
Collaborator

Updates src/tools/cargo.

cc @ehuss

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2020

📌 Commit 868d559 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented May 1, 2020

⌛ Testing commit 868d559 with merge a91d648...

@bors
Copy link
Contributor

bors commented May 1, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing a91d648 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2020
@bors bors merged commit a91d648 into rust-lang:master May 1, 2020
@rust-highfive rust-highfive mentioned this pull request May 1, 2020
Closed
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71742!

Tested on commit a91d648.
Direct link to PR: #71742

💔 rls on windows: test-pass → build-fail (cc @Xanewok).
💔 rls on linux: test-pass → build-fail (cc @Xanewok).
💔 rustc-dev-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 1, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#71742!
33b4324 
Tested on commit rust-lang/rust@a91d648.
Direct link to PR: <rust-lang/rust#71742>

💔 rls on windows: test-pass → build-fail (cc @Xanewok).
💔 rls on linux: test-pass → build-fail (cc @Xanewok).
💔 rustc-dev-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch May 8, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rust-highfive @Dylan-DPC-zz @bors @ehuss