Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update std and extra crate docs #7176

Closed
wants to merge 1 commit into from
Closed

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 16, 2013

Fix a few inaccuracies and bring things more up to date.

primitives (`task`, `comm`), platform abstractions (`os` and `path`), basic
I/O abstractions (`io`), common traits (`kinds`, `ops`, `cmp`, `num`,
`to_str`), and complete bindings to the C standard library (`libc`).
The Rust standard library is a group of interrelated modules that define
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think defining would work better than that define.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks for review.

Fix a few inaccuracies and bring things more up to date.
@kud1ing
Copy link

kud1ing commented Jun 17, 2013

Do we want the Sqlite-bindings in extra?

@rkbodenner
Copy link
Contributor

Saw this PR after I'd submitted #7197, so I updated mine with your text changes (it adds a few more small fixes).

@brson
Copy link
Contributor Author

brson commented Jun 17, 2013

Ok closing this.

@kud1ing I don't want to pull in any new dependencies right now. Eventually I hope that extra gets broken up into individual packages, some of them granted 'supported' status, some not. Once we have that infrastructure we can start making guarantees about supported sqlite bindings, etc.

@brson brson closed this Jun 17, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 20, 2021
…r=llogiq

New lint: `unused_async`

changelog: Adds a lint, `unused_async`, which checks for async functions with no await statements

`unused_async` is a lint that reduces code smell and overhead by encouraging async functions to be refactored into synchronous functions.

Fixes rust-lang#7176

### Examples

```rust
async fn get_random_number() -> i64 {
    4 // Chosen by fair dice roll. Guaranteed to be random.
}
```

Could be written as:

```rust
fn get_random_number() -> i64 {
    4 // Chosen by fair dice roll. Guaranteed to be random.
}
```

Something like this, however, should **not** be caught by clippy:
```rust
#[async_trait]
trait AsyncTrait {
    async fn foo();
}

struct Bar;

#[async_trait]
impl AsyncTrait for Bar {
    async fn foo() {
        println!("bar");
    }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants