Uncomment test code for failure to use Box::pin
#71781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @tmandry I feel that the current output isn't quite great, but I believe it is a good enough stop gap while we see how people hit this in the wild. |
|
Agreed, and I don't see anything that would lead a user down the wrong path. Thanks for improving these! @bors r+ rollup |
|
📌 Commit b3a8f21 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71712 (Miri: port error backtraces to std::backtrace) - rust-lang#71736 (bootstrap: also apply unused-attributes hack without deny_warnings) - rust-lang#71738 (remove AllocId generalization of Pointer) - rust-lang#71739 (remove obsolete comment) - rust-lang#71781 (Uncomment test code for failure to use `Box::pin`) - rust-lang#71782 (Use a non-existent test path instead of clobbering /dev/null) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #69083.