-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #71803
Rollup of 5 pull requests #71803
Commits on May 1, 2020
-
doc: make Stack and StackElement a little pretty
Also, fix rustdoc warnings.
Configuration menu - View commit details
-
Copy full SHA for ad46044 - Browse repository at this point
Copy the full SHA ad46044View commit details
Commits on May 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b5c1f45 - Browse repository at this point
Copy the full SHA b5c1f45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d62be - Browse repository at this point
Copy the full SHA 60d62beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80d04cc - Browse repository at this point
Copy the full SHA 80d04ccView commit details -
Suggestion for immutable reference -> mutable pointer should be emitted
as `Applicability::Unspecified`
Configuration menu - View commit details
-
Copy full SHA for 089d4bb - Browse repository at this point
Copy the full SHA 089d4bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a212c1 - Browse repository at this point
Copy the full SHA 9a212c1View commit details -
Update src/libserialize/json.rs
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3406b53 - Browse repository at this point
Copy the full SHA 3406b53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be52b5 - Browse repository at this point
Copy the full SHA 3be52b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff86a45 - Browse repository at this point
Copy the full SHA ff86a45View commit details -
Rollup merge of rust-lang#71726 - ldm0:ref2ptr, r=oli-obk
Suggest deref when coercing `ty::Ref` to `ty::RawPtr` with arbitrary mutability Fixes rust-lang#71676 1. Implement dereference suggestion when coercing `ty::Ref` to `ty::RawPtr` with arbitrary mutability. 2. Extract the dereference steps into `deref_steps()`, which removes all the `use` and `pub` noise introduced by last PR rust-lang#71540, and makes the code more readable. 3. Use the `remove_prefix()` closure which makes the prefix removal more readable. 4. Introduce `Applicability` as a return value of `check_ref` to suggest `Applicability::Unspecified` suggestion. **Special**: I found it is not possible to genereate `Applicability::MachineApplicable` suggestion for situation like this: ```rust use std::ops::Deref; use std::ops::DerefMut; struct Bar(u8); struct Foo(Bar); struct Emm(Foo); impl Deref for Bar{ type Target = u8; fn deref(&self) -> &Self::Target { &self.0 } } impl Deref for Foo { type Target = Bar; fn deref(&self) -> &Self::Target { &self.0 } } impl Deref for Emm { type Target = Foo; fn deref(&self) -> &Self::Target { &self.0 } } impl DerefMut for Bar{ fn deref_mut(&mut self) -> &mut Self::Target { &mut self.0 } } impl DerefMut for Foo { fn deref_mut(&mut self) -> &mut Self::Target { &mut self.0 } } impl DerefMut for Emm { fn deref_mut(&mut self) -> &mut Self::Target { &mut self.0 } } fn main() { let a = Emm(Foo(Bar(0))); let _: *mut u8 = &a; //~ ERROR mismatched types } ``` We may suggest `&mut ***a` here, but the `a` is not declared as mutable variable. And also when processing HIR, it's not possible to check if `a` is declared as a mutable variable (currently we do borrow checking with MIR). So we cannot ensure that suggestion when coercing immutable reference to mutable pointer is always machine applicable. Therefore I added a `Applicability` return value in `check_ref()`. And move the `immutable reference -> mutable pointer` situation into a sperate test file without `run-rustfix`. (It seems that `run-rustfix` will also adopt `Applicability::Unspecified` suggestion, which is strange)
Configuration menu - View commit details
-
Copy full SHA for b121d7c - Browse repository at this point
Copy the full SHA b121d7cView commit details -
Rollup merge of rust-lang#71767 - tshepang:stack-stuff, r=jonas-schie…
…vink doc: make Stack and StackElement a little pretty Also, fix rustdoc warnings.
Configuration menu - View commit details
-
Copy full SHA for a299abd - Browse repository at this point
Copy the full SHA a299abdView commit details -
Rollup merge of rust-lang#71777 - petrochenkov:crtype, r=Mark-Simulacrum
cleanup: `config::CrateType` -> `CrateType`
Configuration menu - View commit details
-
Copy full SHA for c311c0d - Browse repository at this point
Copy the full SHA c311c0dView commit details -
Rollup merge of rust-lang#71784 - Xaeroxe:patch-1, r=jonas-schievink
Remove recommendation for unmaintained dirs crate See rust-lang#71684 for reasoning here
Configuration menu - View commit details
-
Copy full SHA for 48a2946 - Browse repository at this point
Copy the full SHA 48a2946View commit details -
Rollup merge of rust-lang#71787 - tshepang:rustdoc-warnings, r=varkor
fix rustdoc warnings
Configuration menu - View commit details
-
Copy full SHA for ffd9301 - Browse repository at this point
Copy the full SHA ffd9301View commit details