Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #71807

Merged
merged 18 commits into from
May 3, 2020
Merged

Rollup of 7 pull requests #71807

merged 18 commits into from
May 3, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

LeSeulArtichaut and others added 18 commits May 1, 2020 14:17
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
…r=hanna-kruppe

Implement RFC 2396: `#[target_feature]` 1.1

Tracking issue: rust-lang#69098

r? @nikomatsakis
cc @gnzlbg @joshtriplett
…vink

doc: make Stack and StackElement a little pretty

Also, fix rustdoc warnings.
Mark query function as must_use.

And use the `ensure()` version when the result is not needed.
cleanup: `config::CrateType` -> `CrateType`
Remove recommendation for unmaintained dirs crate

See rust-lang#71684 for reasoning here
…Simulacrum

Update comment regarding SO_REUSEADDR on Windows
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented May 2, 2020

📌 Commit 97cf378 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 2, 2020
@bors
Copy link
Contributor

bors commented May 2, 2020

⌛ Testing commit 97cf378 with merge abfbf82a0c36e1be3ea15685003dd04d81b82579...

@bors
Copy link
Contributor

bors commented May 2, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 2, 2020
@Dylan-DPC-zz
Copy link
Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020
@bors
Copy link
Contributor

bors commented May 2, 2020

⌛ Testing commit 97cf378 with merge c1e0552...

@bors
Copy link
Contributor

bors commented May 3, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing c1e0552 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2020
@bors bors merged commit c1e0552 into rust-lang:master May 3, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71807!

Tested on commit c1e0552.
Direct link to PR: #71807

💔 rustc-dev-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants