Code

Better method call error messages#71827

Code

Closed

Quantumplation wants to merge 21 commits intorust-lang:masterrust-lang/rust:masterfrom

Quantumplation:65853/param-heuristicsQuantumplation/rust:65853/param-heuristicsCopy head branch name to clipboard

Commits

Commits on Dec 31, 2020

• Initial implementation for 65853

  Show description for acd679c
  Quantumplation

  committed
  acd679c

  Copy full SHA for acd679c

• Adds some basic test cases

  Show description for c266c4c
  Quantumplation

  committed
  c266c4c

  Copy full SHA for c266c4c

• Rust cleanup

  Show description for 7fc8e3c
  Quantumplation

  committed
  7fc8e3c

  Copy full SHA for 7fc8e3c

• Prevent an ICE on empty params

  Show description for 5bf45b3
  Quantumplation

  committed
  5bf45b3

  Copy full SHA for 5bf45b3

Commits on Jan 13, 2021

• Interpolate correct types into error messages

  Show description for f1916fa
  Quantumplation

  committed
  f1916fa

  Copy full SHA for f1916fa

• Fix a comment typo

  Show description for ae3c859
  

  Quantumplation

  and

  Joshua Nelson

  authored
  ae3c859

  Copy full SHA for ae3c859

Commits on Jan 14, 2021

• Small tweaks / typos fixed from code review

  Show description for 93ee0af
  Quantumplation

  committed
  93ee0af

  Copy full SHA for 93ee0af

• Add a ton of test cases, refine error messages

  Show description for f369af6
  Quantumplation

  committed
  f369af6

  Copy full SHA for f369af6

Commits on Jan 15, 2021

• Refactor final_arg_types to use a presized array

  Show description for 74faf96
  Quantumplation

  committed
  74faf96

  Copy full SHA for 74faf96

• Remove an if clause that wasn't neccesary

  Quantumplation

  committed
  d455267

  Copy full SHA for d455267

• Make the fn_name more nuanced

  Quantumplation

  committed
  d570d59

  Copy full SHA for d570d59

• Fixed a bug related to invalid arguments

  Show description for 6eb1da0
  Quantumplation

  committed
  6eb1da0

  Copy full SHA for 6eb1da0

• Corrects the spans and types for the Invalid case

  Show description for ddb50d3
  Quantumplation

  committed
  ddb50d3

  Copy full SHA for ddb50d3

• A fix for a &str type check, and a pass at extra span alignment

  Show description for b8c651f
  Quantumplation

  committed
  b8c651f

  Copy full SHA for b8c651f

Commits on Jan 16, 2021

• Add a multipart_suggestion_verbose

  Show description for 28b5a1f
  

  Pi Lanningham

  committed
  28b5a1f

  Copy full SHA for 28b5a1f

Commits on Jan 17, 2021

• Give preference to latter commas

  

  Pi Lanningham

  committed
  552583c

  Copy full SHA for 552583c

• Another round of improvements on spans

  Show description for de1a6c8
  

  Pi Lanningham

  committed
  de1a6c8

  Copy full SHA for de1a6c8

Commits on Jan 19, 2021

• Refactor the check code to simplify the suggestions.

  Show description for 807f656
  

  Pi Lanningham

  committed
  807f656

  Copy full SHA for 807f656

Commits on Feb 6, 2021

• Add back error span labels

  Show description for c3dea90
  Quantumplation

  committed
  c3dea90

  Copy full SHA for c3dea90

• Linting and formatting fixes

  Quantumplation

  committed
  1d6bab0

  Copy full SHA for 1d6bab0

Commits on Feb 7, 2021

• --bless error messages

  Show description for 5267285
  Quantumplation

  committed
  5267285

  Copy full SHA for 5267285