Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Vec::remove_item as discussed in #40062 #71834

Closed
wants to merge 1 commit into from
Closed

Remove Vec::remove_item as discussed in #40062 #71834

wants to merge 1 commit into from

Conversation

LukasKalbertodt
Copy link
Member

Tracking issue. I'm not quite sure if we want a transition period where we just deprecated the method without removing.

@fbstj fbstj mentioned this pull request May 7, 2020
Closed
@Mark-Simulacrum
Copy link
Member

I think we should indeed deprecate and wait for some time (maybe a cycle or so) before removing entirely.

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2020
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2020
@dtolnay
Copy link
Member

dtolnay commented May 22, 2020

@kornelski would you be able to take over this PR? Lukas has been busy recently and I saw that you pursued this in #71979.

@kornelski
Copy link
Contributor

OK

@Elinvynia Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2020
@LukasKalbertodt LukasKalbertodt mentioned this pull request Jun 20, 2020
Merged
@LukasKalbertodt
Copy link
Member Author

I haven't seen any activity here, so I just went ahead and opened #73539.

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 20, 2020
@RalfJung
Rollup merge of rust-lang#73539 - LukasKalbertodt:deprecate-vec-remov…
c1cad70 
…e-item, r=Mark-Simulacrum

Deprecate `Vec::remove_item`

In rust-lang#40062 we decided to remove that method. In rust-lang#71834 it was said that we want to deprecate it for a few cycles before removing it. That's what this PR does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LukasKalbertodt @Mark-Simulacrum @dtolnay @kornelski @joelpalmer @ecstatic-morse @Elinvynia