Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make std::char functions and constants associated to char. #71854

Merged
merged 2 commits into from
May 21, 2020
Merged

Make std::char functions and constants associated to char. #71854

merged 2 commits into from
May 21, 2020

Conversation

eduardosm
Copy link
Contributor

First step to fix #71763.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2020
@@ -92,15 +92,15 @@ const MAX_THREE_B: u32 = 0x10000;
/// [Unicode Scalar Value]: http://www.unicode.org/glossary/#unicode_scalar_value
/// [Code Point]: http://www.unicode.org/glossary/#code_point
#[stable(feature = "rust1", since = "1.0.0")]
pub const MAX: char = '\u{10ffff}';
pub const MAX: char = char::MAX;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub use instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible because here char:: is not a module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustdoc can export primitive types but not associated constants. This could be improved.
Anyway, it currently rustdoc can't do that, just ignore these comments.

src/libcore/char/methods.rs Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

r? @LukasKalbertodt for libs team approval

@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2020
@Elinvynia Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2020
@Dylan-DPC-zz
Copy link

r? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented May 21, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 21, 2020

📌 Commit 0e12a9d has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
…ts, r=Amanieu

Make `std::char` functions and constants associated to `char`.

First step to fix rust-lang#71763.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#71854 (Make `std::char` functions and constants associated to `char`.)
 - rust-lang#72111 (rustc-book: Document `-Z strip=val` option)
 - rust-lang#72272 (Fix going back in history to a search result page on firefox)
 - rust-lang#72296 (Suggest installing VS Build Tools in more situations)
 - rust-lang#72365 (Remove unused `StableHashingContext::node_to_hir_id` method)
 - rust-lang#72371 (FIX - Char documentation for unexperienced users)
 - rust-lang#72397 (llvm: Expose tiny code model to users)

Failed merges:

r? @ghost
@bors bors merged commit 25028ad into rust-lang:master May 21, 2020
@eduardosm eduardosm deleted the assoc-char-funcs-and-consts branch May 26, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for associated functions and consts of std::char.
10 participants